Minor redesigns of color chooser view.

Minor redesigns of color chooser view.

- crosshair is slightly bigger.
- hue indicator triangles are slightly bigger.
- now it has a "selected color" patch besides of the textfield.

R=sadrul@chromium.org
BUG=140201
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150487

[sadrul, 2012-08-02 15:35:27]

LGTM

http://codereview.chromium.org/10828111/diff/2001/ui/views/color_chooser/colo...
File ui/views/color_chooser/color_chooser_view.cc (right):

http://codereview.chromium.org/10828111/diff/2001/ui/views/color_chooser/colo...
ui/views/color_chooser/color_chooser_view.cc:94: // ColorChooserView::HueView
definition.
I think you can do with just 'ColorChooserView::HueView'

http://codereview.chromium.org/10828111/diff/2001/ui/views/color_chooser/colo...
ui/views/color_chooser/color_chooser_view.cc:160: SK_ColorGRAY);
Should we get the color from the theme instead of always using gray here (and
other places)?

[Jun Mukai, 2012-08-06 10:00:36]

sadrul,

I changed the design as the discussion with kbx and UI guys.  Please take
another look at this.

[sadrul, 2012-08-07 13:19:20]

http://codereview.chromium.org/10828111/diff/7001/ui/views/color_chooser/colo...
File ui/views/color_chooser/color_chooser_view.cc (right):

http://codereview.chromium.org/10828111/diff/7001/ui/views/color_chooser/colo...
ui/views/color_chooser/color_chooser_view.cc:363: View* textfield =
parent()->child_at(0);
This doesn't look like a good way of doing this. Perhaps use a grid-layout for
|container2| or override ColorChooserView::Layout instead.

[Jun Mukai, 2012-08-07 14:03:03]

http://codereview.chromium.org/10828111/diff/7001/ui/views/color_chooser/colo...
File ui/views/color_chooser/color_chooser_view.cc (right):

http://codereview.chromium.org/10828111/diff/7001/ui/views/color_chooser/colo...
ui/views/color_chooser/color_chooser_view.cc:363: View* textfield =
parent()->child_at(0);
On 2012/08/07 13:19:20, sadrul wrote:
> This doesn't look like a good way of doing this. Perhaps use a grid-layout for
> |container2| or override ColorChooserView::Layout instead.

thanks.  changed to use GridLayout.

[sadrul, 2012-08-07 14:05:11]

LGTM

[commit-bot: I haz the power, 2012-08-07 14:33:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/10828111/5

[commit-bot: I haz the power, 2012-08-07 14:41:05]

Try job failure for 10828111-5 on linux_chromeos for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-08-08 01:09:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/10828111/5

[commit-bot: I haz the power, 2012-08-08 02:27:32]

Change committed as 150487