Issue 10828109: Replace IF_EXPECT* macros with ASSERT* in gdata_wapi_parser_unittest.cc

Issue 10828109: Replace IF_EXPECT* macros with ASSERT* in gdata_wapi_parser_unittest.cc (Closed)

Created:
8 years, 4 months ago by Haruki Sato

Modified:
8 years, 4 months ago

Reviewers:
satorux1, kochi

CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Replace IF_EXPECT* macros with ASSERT* in gdata_wapi_parser_unittest.cc Remove - IF_EXPECT_EQ - IF_EXPECT_TRUE macros and use - ASSERT_EQ - ASSERT_TRUE in gdata_wapi_parser_unittest.cc BUG=139956 TEST=unit_tests --gtest_filter="GDataWAPIParserTest*" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149568

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Style fix. #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+149 lines, -181 lines)			Patch
	M	chrome/browser/chromeos/gdata/gdata_wapi_parser_unittest.cc	View	1	6 chunks	+149 lines, -181 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

kochi

lgtm with a nit. You need OWNERS review in chrome/browser/chromeos/gdata/OWNERS. https://chromiumcodereview.appspot.com/10828109/diff/1002/chrome/browser/chromeos/gdata/gdata_wapi_parser_unittest.cc File chrome/browser/chromeos/gdata/gdata_wapi_parser_unittest.cc (right): https://chromiumcodereview.appspot.com/10828109/diff/1002/chrome/browser/chromeos/gdata/gdata_wapi_parser_unittest.cc#newcode330 ...

8 years, 4 months ago (2012-08-01 09:38:59 UTC) #2

Haruki Sato

Satoru-san, could you OWNERS review this change? Thanks. https://chromiumcodereview.appspot.com/10828109/diff/1002/chrome/browser/chromeos/gdata/gdata_wapi_parser_unittest.cc File chrome/browser/chromeos/gdata/gdata_wapi_parser_unittest.cc (right): https://chromiumcodereview.appspot.com/10828109/diff/1002/chrome/browser/chromeos/gdata/gdata_wapi_parser_unittest.cc#newcode330 chrome/browser/chromeos/gdata/gdata_wapi_parser_unittest.cc:330: icon_url.spec()); ...

8 years, 4 months ago (2012-08-01 11:42:15 UTC) #3

satorux1

LGTM. Thanks! BTW, you can also ask hashimoto@ for code review.

8 years, 4 months ago (2012-08-01 16:07:30 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haruki@chromium.org/10828109/5002

8 years, 4 months ago (2012-08-02 01:25:58 UTC) #5

Change committed as 149568

Expand Messages | Collapse Messages