Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 10828092: [File Manager] Better message when trying to open unsupported files (Closed)

Created:
8 years, 4 months ago by Vladislav Kaznacheev
Modified:
8 years, 4 months ago
Reviewers:
SeRya
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

[File Manager] Better message when trying to open unsupported files We used to show different messages when opening unsupported files from the Files app and from the Downloads page. I made them more similar, although the one displayed from C++ does not have links because the standard warning dialog does not support HTML. BUG=139523 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149179

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -9 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/resources/file_manager/js/file_tasks.js View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/js/mock_chrome.js View 1 2 2 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Vladislav Kaznacheev
Please review
8 years, 4 months ago (2012-07-31 11:26:29 UTC) #1
SeRya
lgtm http://codereview.chromium.org/10828092/diff/1/chrome/browser/resources/file_manager/js/mock_chrome.js File chrome/browser/resources/file_manager/js/mock_chrome.js (right): http://codereview.chromium.org/10828092/diff/1/chrome/browser/resources/file_manager/js/mock_chrome.js#newcode596 chrome/browser/resources/file_manager/js/mock_chrome.js:596: NO_ACTION_FOR_FILE: "This file type is not supported. Please ...
8 years, 4 months ago (2012-07-31 12:24:59 UTC) #2
Vladislav Kaznacheev
https://chromiumcodereview.appspot.com/10828092/diff/1/chrome/browser/resources/file_manager/js/mock_chrome.js File chrome/browser/resources/file_manager/js/mock_chrome.js (right): https://chromiumcodereview.appspot.com/10828092/diff/1/chrome/browser/resources/file_manager/js/mock_chrome.js#newcode596 chrome/browser/resources/file_manager/js/mock_chrome.js:596: NO_ACTION_FOR_FILE: "This file type is not supported. Please visit ...
8 years, 4 months ago (2012-07-31 12:41:37 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-07-31 14:00:24 UTC) #4

Powered by Google App Engine
This is Rietveld 408576698