Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 10828088: aura: use TestWebGraphicsContext3D for the shared contexts (Closed)

Created:
8 years, 4 months ago by piman
Modified:
8 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, jonathan.backer, Ian Vollick, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Visibility:
Public.

Description

aura: use TestWebGraphicsContext3D for the shared contexts Previously, we would use a regular command buffer context for the shared offscreen contexts, which is unable to share resources with the TestWebGraphicsContext3D, raising asserts if for example filters are used in layers. This change makes us use TestWebGraphicsContext3D for all contexts when using --test-compositor BUG=139300 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149357

Patch Set 1 #

Patch Set 2 : win fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -2 lines) Patch
M content/browser/renderer_host/image_transport_factory.cc View 3 chunks +11 lines, -0 lines 0 comments Download
M content/common/webkitplatformsupport_impl.h View 3 chunks +5 lines, -1 line 0 comments Download
M content/common/webkitplatformsupport_impl.cc View 3 chunks +12 lines, -0 lines 0 comments Download
M ui/compositor/test_web_graphics_context_3d.h View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
piman
8 years, 4 months ago (2012-07-31 04:30:35 UTC) #1
sky
Do you need to update gyp files too? I don't think we build TestWebGraphicsContext3D outside ...
8 years, 4 months ago (2012-07-31 19:06:41 UTC) #2
piman
On Tue, Jul 31, 2012 at 12:06 PM, <sky@chromium.org> wrote: > Do you need to ...
8 years, 4 months ago (2012-07-31 19:54:31 UTC) #3
sky
LGTM
8 years, 4 months ago (2012-07-31 23:35:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/10828088/1
8 years, 4 months ago (2012-07-31 23:42:46 UTC) #5
commit-bot: I haz the power
Try job failure for 10828088-1 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-01 00:31:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/10828088/8002
8 years, 4 months ago (2012-08-01 01:12:01 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-01 02:33:41 UTC) #8
Change committed as 149357

Powered by Google App Engine
This is Rietveld 408576698