Issue 10828085: [Web Intents] Localization of intent titles for CWS suggestions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10828085: [Web Intents] Localization of intent titles for CWS suggestions (Closed)

Created:
8 years, 4 months ago by groby-ooo-7-16

Modified:
8 years, 4 months ago

Reviewers:
Matt Perry, Greg Billock

CC:
chromium-reviews, gbillock+watch_chromium.org, smckay+watch_chromium.org, mihaip-chromium-reviews_chromium.org, jshin+watch_chromium.org, Aaron Boodman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Web Intents] Localization of intent titles for CWS suggestions This is a re-upload of patch from issue 10790087, which got reverted for a memory leak in the tests. This CL fixes the test. R=mpcomplete@chromium.org,gbillock@chromium.org BUG=130432 TEST=CWSIntentsRegistryTest.LocalizeMatchingLocale:ExtensionL10nUtil.GetAllFallbackLocales:ExtensionL10nUtil.LoadMessageCatalogs* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149472

Patch Set 1 #

Patch Set 2 : Fix destruction order. #

Patch Set 3 : Fix misplaced period #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+229 lines, -35 lines)			Patch
M	chrome/browser/intents/cws_intents_registry.h	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/intents/cws_intents_registry.cc	View		3 chunks	+45 lines, -0 lines	0 comments	Download
M	chrome/browser/intents/cws_intents_registry_unittest.cc	View	1 2	6 chunks	+153 lines, -29 lines	0 comments	Download
M	chrome/common/extensions/extension_l10n_util.h	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/extension_l10n_util.cc	View		2 chunks	+11 lines, -4 lines	0 comments	Download
M	chrome/common/extensions/extension_l10n_util_unittest.cc	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Greg Billock

On 2012/07/31 17:30:09, groby wrote: > Please review lgtm Note Matt: only diff is in ...

8 years, 4 months ago (2012-07-31 18:43:25 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/10828085/5001

8 years, 4 months ago (2012-08-01 18:17:39 UTC) #4

Change committed as 149472

Expand Messages | Collapse Messages