Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Issue 10828075: Remove deprecated aura_shell_unittests target (Closed)

Created:
8 years, 4 months ago by James Cook
Modified:
8 years, 4 months ago
Reviewers:
Peter Mayo, Daniel Erat
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Remove deprecated aura_shell_unittests target This target has been renamed to ash_unittests. We were temporarily building ash_unittests and copying it to aura_shell_unittests. The buildbots have been reconfigured and restarted, so they should look for the new name. We can now eliminate the copy step and the old target. BUG=110107 TEST=green buildbots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150578

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -38 lines) Patch
M ash/ash.gyp View 1 1 chunk +0 lines, -32 lines 0 comments Download
M build/all.gyp View 1 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
James Cook
Peter, PTAL. Sky, I need OWNERS approval for the ash/ change.
8 years, 4 months ago (2012-07-30 18:38:32 UTC) #1
James Cook
Dan, can I get OWNERS approval for the ash/ change? Sky seemed to be at ...
8 years, 4 months ago (2012-07-30 20:33:03 UTC) #2
Daniel Erat
LGTM (Wow, I didn't even know that the renaming had finally happened!)
8 years, 4 months ago (2012-07-30 20:45:37 UTC) #3
Peter Mayo
LGTM
8 years, 4 months ago (2012-07-30 23:02:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/10828075/10001
8 years, 4 months ago (2012-08-08 15:53:50 UTC) #5
commit-bot: I haz the power
Change committed as 150578
8 years, 4 months ago (2012-08-08 17:27:20 UTC) #6
James Cook
8 years, 4 months ago (2012-08-08 20:54:09 UTC) #7
This landed and appears to have stuck.  After a month of waiting (and 7 months
since the bug was filed), this cleanup is done!

Powered by Google App Engine
This is Rietveld 408576698