Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Issue 10828069: return NULL if we failed to allocate a cairo surface, rather than waiting for skia to (Closed)

Created:
8 years, 4 months ago by reed1
Modified:
8 years, 4 months ago
CC:
chromium-reviews, vandebo (ex-Chrome)
Visibility:
Public.

Description

return NULL if we failed to allocate a cairo surface, rather than waiting for skia to crash with a null-bitmap-ptr. The callers already check for a NULL-BitmapPlatformDevice return value. Places where we perform this check/return on other platforms bitmap_platform_device_win.cc#187 iff CreateDIBSection failed bitmap_platform_device_mac.cc#120,144 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148959

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M skia/ext/bitmap_platform_device_linux.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
reed1
control #19 https://chromiumcodereview.appspot.com/10533136
8 years, 4 months ago (2012-07-30 15:25:14 UTC) #1
vandebo (ex-Chrome)
8 years, 4 months ago (2012-07-30 16:13:01 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698