Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: src/ia32/full-codegen-ia32.cc

Issue 10828066: Inline simple getter calls. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Incorporated review comments. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen.cc ('k') | src/mips/full-codegen-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2196 matching lines...) Expand 10 before | Expand all | Expand 10 after
2207 2207
2208 2208
2209 void FullCodeGenerator::VisitProperty(Property* expr) { 2209 void FullCodeGenerator::VisitProperty(Property* expr) {
2210 Comment cmnt(masm_, "[ Property"); 2210 Comment cmnt(masm_, "[ Property");
2211 Expression* key = expr->key(); 2211 Expression* key = expr->key();
2212 2212
2213 if (key->IsPropertyName()) { 2213 if (key->IsPropertyName()) {
2214 VisitForAccumulatorValue(expr->obj()); 2214 VisitForAccumulatorValue(expr->obj());
2215 __ mov(edx, result_register()); 2215 __ mov(edx, result_register());
2216 EmitNamedPropertyLoad(expr); 2216 EmitNamedPropertyLoad(expr);
2217 PrepareForBailoutForId(expr->ReturnId(), TOS_REG);
2217 context()->Plug(eax); 2218 context()->Plug(eax);
2218 } else { 2219 } else {
2219 VisitForStackValue(expr->obj()); 2220 VisitForStackValue(expr->obj());
2220 VisitForAccumulatorValue(expr->key()); 2221 VisitForAccumulatorValue(expr->key());
2221 __ pop(edx); // Object. 2222 __ pop(edx); // Object.
2222 __ mov(ecx, result_register()); // Key. 2223 __ mov(ecx, result_register()); // Key.
2223 EmitKeyedPropertyLoad(expr); 2224 EmitKeyedPropertyLoad(expr);
2224 context()->Plug(eax); 2225 context()->Plug(eax);
2225 } 2226 }
2226 } 2227 }
(...skipping 2321 matching lines...) Expand 10 before | Expand all | Expand 10 after
4548 *stack_depth = 0; 4549 *stack_depth = 0;
4549 *context_length = 0; 4550 *context_length = 0;
4550 return previous_; 4551 return previous_;
4551 } 4552 }
4552 4553
4553 #undef __ 4554 #undef __
4554 4555
4555 } } // namespace v8::internal 4556 } } // namespace v8::internal
4556 4557
4557 #endif // V8_TARGET_ARCH_IA32 4558 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/hydrogen.cc ('k') | src/mips/full-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698