browser_tests.isolate: fetch whole ../third_party/WebKit/Tools/Scripts/webkitpy/

chrome/browser_tests.isolate

Index: chrome/browser_tests.isolate
diff --git a/chrome/browser_tests.isolate b/chrome/browser_tests.isolate
index 5ccb686194ecd42c16b0d62102d322a25a7df16f..0354319771c4390b06cd4592dd467ba01c2e54c8 100644
--- a/chrome/browser_tests.isolate
+++ b/chrome/browser_tests.isolate
@@ -110,9 +110,6 @@
           '../third_party/WebKit/Tools/Scripts/new-run-webkit-httpd',
           '../third_party/WebKit/Tools/Scripts/webkit-build-directory',
           '../third_party/WebKit/Tools/Scripts/webkitdirs.pm',

[abarth-chromium, 2012/07/27 23:17:22]

The stuff above this line is all wrong too.  We're very likely to rename
new-run-webkit-httpd to run-webkit-httpd in the future.  Hardcoding this
detailed information about the structure of the WebKit repository is breaks the
WebKit API.

[M-A Ruel, 2012/07/27 23:33:04]

This will be handled in a follow up CL. Technically, this should be a
.gypi/.isolate file inside the WebKit repository but that is out of scope of
this CL. The swarm slaves are designed to sustain fetching an additional 3000+
files but I'd rather not force them to do it yet. I'll just disable all XXX_run
targets for most masters as I'm going on vacation and don't want to leave the
burden on Chris.

-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/version_check.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/httpd2.pem',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/lighttpd.conf',
           '../third_party/simplejson/__init__.py',
           '../third_party/simplejson/decoder.py',
           '../third_party/simplejson/encoder.py',
@@ -982,119 +979,6 @@
           '../net/data/ssl/certificates/ok_cert.pem',
           '../net/data/ssl/certificates/root_ca_cert.crt',
           '../third_party/WebKit/Tools/Scripts/new-run-webkit-websocketserver',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/__init__.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/__init__.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/__init__.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/changelog.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/checkout.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/commitinfo.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/deps.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/diff_parser.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/__init__.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/commitmessage.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/detection.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/svn.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/config/__init__.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/config/committers.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/config/urls.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/editdistance.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/find_files.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/host.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/memoized.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/net/__init__.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/net/bugzilla/__init__.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/net/bugzilla/attachment.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/net/bugzilla/bug.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot/__init__.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/net/credentials.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/net/failuremap.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/net/file_uploader.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/net/networktransaction.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/net/regressionwindow.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/net/resultsjsonparser.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/net/web.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/read_checksum_from_png.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/system/__init__.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/system/autoinstall.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/system/deprecated_logging.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/system/environment.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/system/file_lock.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/system/logutils.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/system/path.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/system/platforminfo.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/system/stack_utils.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/system/systemhost.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/system/user.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/system/workspace.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/watchlist/__init__.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/watchlist/amountchangedpattern.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/watchlist/changedlinepattern.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/watchlist/filenamepattern.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/watchlist/watchlist.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/watchlist/watchlistloader.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/watchlist/watchlistparser.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/common/watchlist/watchlistrule.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/__init__.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/__init__.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/worker.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/__init__.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/__init__.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/result_summary.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_input.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_results.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/__init__.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/builders.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_linux.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/config.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/http_lock.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/webkit.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/__init__.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/apache_http_server.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/http_server.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/http_server_base.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/websocket_server.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/__init__.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/metered_stream.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/BeautifulSoup.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/__init__.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/mod_pywebsocket/__init__.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hixie75.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/mod_pywebsocket/http_header_util.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/mod_pywebsocket/memorizingfile.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/mod_pywebsocket/msgutil.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/mod_pywebsocket/stream.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/tool/__init__.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/tool/grammar.py',
           '<(PRODUCT_DIR)/locales/en-US.pak',
           '<(PRODUCT_DIR)/test_data/chrome/test/data/webui/assertions.js',
           '<(PRODUCT_DIR)/test_data/chrome/test/data/webui/chrome_send_browsertest.js',
@@ -1327,7 +1211,7 @@
           '../third_party/WebKit/LayoutTests/http/tests/websocket/tests/hybi/workers/resources/protocol-test_wsh.py',
           '../third_party/WebKit/LayoutTests/http/tests/websocket/tests/hybi/workers/resources/simple_wsh.py',
           '../third_party/WebKit/LayoutTests/http/tests/websocket/tests/hybi/zero-length-text_wsh.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/',
+          '../third_party/WebKit/Tools/Scripts/webkitpy/',

[abarth-chromium, 2012/07/27 23:16:00]

This is wrong.  The existence of webkitpy is an implementation detail of WebKit.
 I'd prefer if you fetched the entire Tools directory as one unit, but if that's
too big, fetching the Tool/Scripts directory is probably ok.

           '<(PRODUCT_DIR)/plugins/',
           '<(PRODUCT_DIR)/test_data/chrome/browser/ui/webui/extensions/',
           '<(PRODUCT_DIR)/test_data/chrome/browser/ui/webui/help/',
@@ -1399,10 +1283,6 @@
     ['OS=="win"', {
       'variables': {
         'isolate_dependency_tracked': [
-          '../third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py',
-          '../third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/ordered_dict.py',
           '../third_party/cygwin/bin/bash.exe',
           '../third_party/cygwin/setup_mount.bat',
           '../third_party/psyco_win32/psyco/__init__.py',