browser_tests.isolate: fetch whole ../third_party/WebKit/Tools/Scripts/webkitpy/

browser_tests.isolate: fetch whole ../third_party/WebKit/Tools/Scripts/webkitpy/

Do not individual files that are needed since the list of needed files for
new-run-webkit-websocketserver is too often changing.

Contrary to the previous .isolate CLs, this one was done manually. A rule in isolate_common.py will be added in a follow up change.

TBR=dpranke@chromium.org
NOTRY=true
BUG=139426
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148850

[abarth-chromium, 2012-07-27 23:16:00]

https://chromiumcodereview.appspot.com/10828059/diff/1/chrome/browser_tests.i...
File chrome/browser_tests.isolate (right):

https://chromiumcodereview.appspot.com/10828059/diff/1/chrome/browser_tests.i...
chrome/browser_tests.isolate:1214:
'../third_party/WebKit/Tools/Scripts/webkitpy/',
This is wrong.  The existence of webkitpy is an implementation detail of WebKit.
 I'd prefer if you fetched the entire Tools directory as one unit, but if that's
too big, fetching the Tool/Scripts directory is probably ok.

[abarth-chromium, 2012-07-27 23:17:22]

https://chromiumcodereview.appspot.com/10828059/diff/1/chrome/browser_tests.i...
File chrome/browser_tests.isolate (right):

https://chromiumcodereview.appspot.com/10828059/diff/1/chrome/browser_tests.i...
chrome/browser_tests.isolate:112:
'../third_party/WebKit/Tools/Scripts/webkitdirs.pm',
The stuff above this line is all wrong too.  We're very likely to rename
new-run-webkit-httpd to run-webkit-httpd in the future.  Hardcoding this
detailed information about the structure of the WebKit repository is breaks the
WebKit API.

[M-A Ruel, 2012-07-27 23:33:04]

https://chromiumcodereview.appspot.com/10828059/diff/1/chrome/browser_tests.i...
File chrome/browser_tests.isolate (right):

https://chromiumcodereview.appspot.com/10828059/diff/1/chrome/browser_tests.i...
chrome/browser_tests.isolate:112:
'../third_party/WebKit/Tools/Scripts/webkitdirs.pm',
On 2012/07/27 23:17:22, abarth wrote:
> The stuff above this line is all wrong too.  We're very likely to rename
> new-run-webkit-httpd to run-webkit-httpd in the future.  Hardcoding this
> detailed information about the structure of the WebKit repository is breaks
the
> WebKit API.

This will be handled in a follow up CL. Technically, this should be a
.gypi/.isolate file inside the WebKit repository but that is out of scope of
this CL. The swarm slaves are designed to sustain fetching an additional 3000+
files but I'd rather not force them to do it yet. I'll just disable all XXX_run
targets for most masters as I'm going on vacation and don't want to leave the
burden on Chris.

[commit-bot: I haz the power, 2012-07-27 23:33:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/10828059/1

[commit-bot: I haz the power, 2012-07-27 23:43:22]

Change committed as 148850