Issue 10828050: Fix segfault in JNIEnv function hooks for test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10828050: Fix segfault in JNIEnv function hooks for test (Closed)

Created:
8 years, 4 months ago by Iain Merrick

Modified:
8 years, 4 months ago

Reviewers:
joth

CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix segfault in JNIEnv function hooks for test On newer JB builds, the JNINativeInterface struct appears to be held in read-only memory so attempting to repoint individual function pointers in it causes segfault. So instead we repoint the top-level struct pointer to refer to our own copy held in read/write memory. BUG=137348 TEST=JNIAndroidTest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148943

Patch Set 1 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -25 lines)			Patch
M	base/android/jni_android_unittest.cc	View	4 chunks	+16 lines, -8 lines	0 comments	Download
M	base/android/scoped_java_ref_unittest.cc	View	2 chunks	+16 lines, -13 lines	0 comments	Download
M	build/android/gtest_filter/base_unittests_disabled	View	1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/husky@chromium.org/10828050/2001

8 years, 4 months ago (2012-07-30 08:31:08 UTC) #3

Change committed as 148943

Expand Messages | Collapse Messages