Move some Pop/Drop calls directly to the places where they are needed.

Move some Pop/Drop calls directly to the places where they are needed.

This is a refactoring-only CL and the fourth one in a series for enabling
inlining of accessors. Later when we try to inline accessor calls, their
arguments must still be on the expression stack, so we must not remove them too
early.

Committed: https://code.google.com/p/v8/source/detail?r=12213

[Michael Starzinger, 2012-07-27 12:26:03]

LGTM (with a nit).

https://chromiumcodereview.appspot.com/10828049/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

https://chromiumcodereview.appspot.com/10828049/diff/1/src/hydrogen.cc#newcod...
src/hydrogen.cc:5073: AddInstruction(new(zone()) HCheckNonSmi(object));
Can we move this down right in front of the block where instructions are
actually emitted? Because this first block is just checking some optimistic
assumptions but not generating any instructions.

[Sven Panne, 2012-07-27 12:35:30]

Landing...

https://chromiumcodereview.appspot.com/10828049/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

https://chromiumcodereview.appspot.com/10828049/diff/1/src/hydrogen.cc#newcod...
src/hydrogen.cc:5073: AddInstruction(new(zone()) HCheckNonSmi(object));
On 2012/07/27 12:26:03, Michael Starzinger wrote:
> Can we move this down right in front of the block where instructions are
> actually emitted? Because this first block is just checking some optimistic
> assumptions but not generating any instructions.

Done.