Issue 10828048: Avoid GC when printing shared function info.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10828048: Avoid GC when printing shared function info. (Closed)

Created:
8 years, 4 months ago by Yang

Modified:
8 years, 4 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Avoid GC when printing shared function info. R=mstarzinger@chromium.org BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=12210

Patch Set 1 #

Total comments: 1

Patch Set 2 : addressed comment #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -1 line)			Patch
	M	src/objects-printer.cc	View		1 chunk	+8 lines, -1 line	0 comments	Download
	M	test/cctest/test-heap.cc	View	1	1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

8 years, 4 months ago (2012-07-27 09:50:26 UTC) #2

LGTM (with a suggestion).

https://chromiumcodereview.appspot.com/10828048/diff/1/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):

https://chromiumcodereview.appspot.com/10828048/diff/1/test/cctest/test-heap....
test/cctest/test-heap.cc:1983: CHECK(maybe_obj->To<JSFunction>(&g_func));
Consider using the following to get to the "g" function ...

Handle<JSFunction> g =
    v8::Utils::OpenHandle(
        *v8::Handle<v8::Function>::Cast(
            v8::Context::GetCurrent()->Global()->Get(v8_str("g"))));

Expand Messages | Collapse Messages