Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 10828041: Revert 148639 - Clean up Prerender field trials. (Closed)

Created:
8 years, 5 months ago by gavinp
Modified:
8 years, 5 months ago
Reviewers:
gavinp
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org, dominich+watch_chromium.org, mmenke
Visibility:
Public.

Description

Revert 148639 - Clean up Prerender field trials. Remove the second comparison group from the prerender field trials, and reorganize the code so that we can compile assert on the summation. The second group has already shown us our numbers are good. The compile time assertion should avoid fat finger errors that we've caught in other reviews (which would otherwise have been a _beta crasher_!). I think we should also give consideration to renaming these histograms for ease of understanding. I know that makes a historic comparison cost, but it makes arriving new in this area so much easier. I'll rebase the multiple prerender CL on top of this. R=dominich@chromium.org BUG=None TEST= Review URL: https://chromiumcodereview.appspot.com/10802062 TBR=gavinp@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148643

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -75 lines) Patch
M chrome/browser/prerender/prerender_field_trial.cc View 6 chunks +73 lines, -75 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
gavinp
8 years, 5 months ago (2012-07-26 23:15:03 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698