Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 10828038: Roll FFMpeg for M22. (Closed)

Created:
8 years, 5 months ago by DaleCurtis
Modified:
8 years, 4 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Roll FFMpeg for M22. Notable new features: - pcm_s16be, pcm_s24be support for chromium. gsm for chromeos. - preroll stripping for mp3 files encoded with LAME or FFmpeg. Includes the usual cadre of bug fixes and enhancements. Fixes a known crash on ARM per fischman. BUG=none TEST=manual, unit tests + asan, tsan, valgrind, etc. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148968

Patch Set 1 : Rebase. #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M DEPS View 1 chunk +2 lines, -2 lines 0 comments Download
M media/ffmpeg/ffmpeg_regression_tests.cc View 4 chunks +8 lines, -6 lines 4 comments Download
M tools/valgrind/drmemory/suppressions.txt View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
DaleCurtis
Vlad's almost finished his manual pass.
8 years, 4 months ago (2012-07-27 22:46:56 UTC) #1
scherkus (not reviewing)
just a few q's http://codereview.chromium.org/10828038/diff/5/media/ffmpeg/ffmpeg_regression_tests.cc File media/ffmpeg/ffmpeg_regression_tests.cc (right): http://codereview.chromium.org/10828038/diff/5/media/ffmpeg/ffmpeg_regression_tests.cc#newcode146 media/ffmpeg/ffmpeg_regression_tests.cc:146: "abc9702fc46f49d6f26da5c62d118cf7"); what's going on with ...
8 years, 4 months ago (2012-07-28 21:31:58 UTC) #2
DaleCurtis
http://codereview.chromium.org/10828038/diff/5/media/ffmpeg/ffmpeg_regression_tests.cc File media/ffmpeg/ffmpeg_regression_tests.cc (right): http://codereview.chromium.org/10828038/diff/5/media/ffmpeg/ffmpeg_regression_tests.cc#newcode146 media/ffmpeg/ffmpeg_regression_tests.cc:146: "abc9702fc46f49d6f26da5c62d118cf7"); On 2012/07/28 21:31:58, scherkus wrote: > what's going ...
8 years, 4 months ago (2012-07-28 22:02:21 UTC) #3
scherkus (not reviewing)
8 years, 4 months ago (2012-07-28 22:39:26 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698