Fix crash in WorkerTest.MultipleTabsQueuedSharedWorker. I could get this consistently when running …

Fix crash in WorkerTest.MultipleTabsQueuedSharedWorker. I could get this consistently when running debug content_browsertests builds in VS.

BUG=69881
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148584

[Andrew T Wilson (Slow), 2012-07-26 17:20:40]

looks good, but I'd like to understand the change more.

http://codereview.chromium.org/10828033/diff/1/content/browser/worker_host/wo...
File content/browser/worker_host/worker_service_impl.cc (right):

http://codereview.chromium.org/10828033/diff/1/content/browser/worker_host/wo...
content/browser/worker_host/worker_service_impl.cc:65: for
(WorkerProcessHost::Instances::iterator i =
Can we clarify what this is doing? Looks like we're blowing away pending shared
workers if there aren't any more filters (parent documents) associated with it?

I guess I'm confused about the difference between what we do here, and what we
do in the next for loop.

[Andrew T Wilson (Slow), 2012-07-26 17:22:14]

I wonder also if this will address http://crbug.com/124695...

[jam, 2012-07-26 17:26:59]

http://codereview.chromium.org/10828033/diff/1/content/browser/worker_host/wo...
File content/browser/worker_host/worker_service_impl.cc (right):

http://codereview.chromium.org/10828033/diff/1/content/browser/worker_host/wo...
content/browser/worker_host/worker_service_impl.cc:65: for
(WorkerProcessHost::Instances::iterator i =
On 2012/07/26 17:20:40, Andrew T Wilson wrote:
> Can we clarify what this is doing? Looks like we're blowing away pending
shared
> workers if there aren't any more filters (parent documents) associated with
it?
> 
> I guess I'm confused about the difference between what we do here, and what we
> do in the next for loop.

I don't claim to understand the worker document set concept, so hard for me to
compare. I think the main issue here is that the filter* is stored in two
places, both in the document_set() below, but also directly on the
WorkerInstance itself. When running the test in VS, and with a few printfs, I
could see that pending_shared_workers_ had objects which pointed to deleted
filters.

[Andrew T Wilson (Slow), 2012-07-26 17:28:40]

OK, I suspect that at some point if I wanted to wrap my head back around this
stuff, we could merge the document set stuff with the list of filters. But for
now, LGTM.