Extensions Docs Server: use addEventListener with branch.js

Extensions Docs Server: use addEventListener with branch.js

Clean up branch.js to use addEventListener.

BUG=131095
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148773

[cduvall, 2012-07-26 18:29:37]

Cleaned up branch.js. I tested it some with node in the terminal, and it works
for all the cases I could think of.

[not at google - send to devlin, 2012-07-27 03:30:39]

lgtm

https://chromiumcodereview.appspot.com/10828027/diff/2001/chrome/common/exten...
File chrome/common/extensions/docs/server2/static/js/branch.js (right):

https://chromiumcodereview.appspot.com/10828027/diff/2001/chrome/common/exten...
chrome/common/extensions/docs/server2/static/js/branch.js:7: if (!this.value)
"this" is evil. This method gets called with the event as its argument; use
that, or hold onto 'branchChooser' and use it directly.

var branchChooser = document.gEBI('branchChooser');

function redirectToBranch() {
  ...
}

https://chromiumcodereview.appspot.com/10828027/diff/2001/chrome/common/exten...
chrome/common/extensions/docs/server2/static/js/branch.js:13: path[index] =
this.value;
need to make sure that if value is empty the element is deleted, otherwise there
will be two // in the path.

https://chromiumcodereview.appspot.com/10828027/diff/2001/chrome/common/exten...
chrome/common/extensions/docs/server2/static/js/branch.js:22: true);
hm haven't seen "true" here before. Why do you need? Just curious.

https://chromiumcodereview.appspot.com/10828027/diff/2001/chrome/common/exten...
File chrome/common/extensions/docs/server2/templates/private/header_body.html
(right):

https://chromiumcodereview.appspot.com/10828027/diff/2001/chrome/common/exten...
chrome/common/extensions/docs/server2/templates/private/header_body.html:2:
<script>window.bootstrap = { branchInfo: {{*branchInfo}} };</script>
Put in the footer? Loading the select without the data existing shouldn't
matter, and the fewer <script>s before the end the better.

[cduvall, 2012-07-27 17:51:10]

https://chromiumcodereview.appspot.com/10828027/diff/2001/chrome/common/exten...
File chrome/common/extensions/docs/server2/static/js/branch.js (right):

https://chromiumcodereview.appspot.com/10828027/diff/2001/chrome/common/exten...
chrome/common/extensions/docs/server2/static/js/branch.js:7: if (!this.value)
On 2012/07/27 03:30:39, kalman wrote:
> "this" is evil. This method gets called with the event as its argument; use
> that, or hold onto 'branchChooser' and use it directly.
> 
> var branchChooser = document.gEBI('branchChooser');
> 
> function redirectToBranch() {
>   ...
> }

Done.

https://chromiumcodereview.appspot.com/10828027/diff/2001/chrome/common/exten...
chrome/common/extensions/docs/server2/static/js/branch.js:13: path[index] =
this.value;
On 2012/07/27 03:30:39, kalman wrote:
> need to make sure that if value is empty the element is deleted, otherwise
there
> will be two // in the path.

Value will never be empty, the branchChooser uses the full name of the default
branch (so 'stable' instead of ''). Also, the value is checked at line 7 if it
is empty.

https://chromiumcodereview.appspot.com/10828027/diff/2001/chrome/common/exten...
chrome/common/extensions/docs/server2/static/js/branch.js:22: true);
On 2012/07/27 03:30:39, kalman wrote:
> hm haven't seen "true" here before. Why do you need? Just curious.

It was so I could use 'this' in the callback. Now I don't need it :)

https://chromiumcodereview.appspot.com/10828027/diff/2001/chrome/common/exten...
File chrome/common/extensions/docs/server2/templates/private/header_body.html
(right):

https://chromiumcodereview.appspot.com/10828027/diff/2001/chrome/common/exten...
chrome/common/extensions/docs/server2/templates/private/header_body.html:2:
<script>window.bootstrap = { branchInfo: {{*branchInfo}} };</script>
On 2012/07/27 03:30:39, kalman wrote:
> Put in the footer? Loading the select without the data existing shouldn't
> matter, and the fewer <script>s before the end the better.

Done.