Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Unified Diff: ppapi/shared_impl/ppb_image_data_shared.cc

Issue 10828023: PPAPI/NaCl: Make NaClIPCAdapter transfer handles more generally (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: re-add gyp files Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/shared_impl/ppb_device_ref_shared.cc ('k') | ppapi/shared_impl/ppb_input_event_shared.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/shared_impl/ppb_image_data_shared.cc
diff --git a/ppapi/shared_impl/ppb_image_data_shared.cc b/ppapi/shared_impl/ppb_image_data_shared.cc
index deec2ac37beb7ce0b0f5486821083847abfdf085..abdea60e270f633b89afdc3c3ffe0147c97f3dd1 100644
--- a/ppapi/shared_impl/ppb_image_data_shared.cc
+++ b/ppapi/shared_impl/ppb_image_data_shared.cc
@@ -4,9 +4,10 @@
#include "ppapi/shared_impl/ppb_image_data_shared.h"
+#include "base/logging.h"
#include "build/build_config.h"
-#if !defined(OS_NACL)
+#if !defined(OS_NACL) && !defined(NACL_WIN64)
#include "third_party/skia/include/core/SkTypes.h"
#endif
@@ -14,18 +15,23 @@ namespace ppapi {
// static
PP_ImageDataFormat PPB_ImageData_Shared::GetNativeImageDataFormat() {
-#if !defined(OS_NACL)
- if (SK_B32_SHIFT == 0)
+#if defined(OS_NACL)
+ // In NaCl, just default to something. If we're wrong, it will be converted
+ // later.
+ // TODO(dmichael): Really proxy this.
+ return PP_IMAGEDATAFORMAT_BGRA_PREMUL;
+#elif defined(NACL_WIN64)
+ // In the NaCl Win64 helper, this shouldn't be called. If we start building
+ // Chrome on Windows 64 for realz, we should really implement this.
+ NOTIMPLEMENTED();
+ return PP_IMAGEDATAFORMAT_BGRA_PREMUL;
+#else
+ return PP_IMAGEDATAFORMAT_BGRA_PREMUL; if (SK_B32_SHIFT == 0)
return PP_IMAGEDATAFORMAT_BGRA_PREMUL;
else if (SK_R32_SHIFT == 0)
return PP_IMAGEDATAFORMAT_RGBA_PREMUL;
else
return PP_IMAGEDATAFORMAT_BGRA_PREMUL; // Default to something on failure.
-#else
- // In NaCl, just default to something. If we're wrong, it will be converted
- // later.
- // TODO(dmichael): Really proxy this.
- return PP_IMAGEDATAFORMAT_BGRA_PREMUL;
#endif
}
« no previous file with comments | « ppapi/shared_impl/ppb_device_ref_shared.cc ('k') | ppapi/shared_impl/ppb_input_event_shared.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698