Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 10828022: Strip IVF headers from VP8 streams before sending them to the OMX decoder. (Closed)

Created:
8 years, 5 months ago by Ami GONE FROM CHROMIUM
Modified:
8 years, 5 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Strip IVF headers from VP8 streams before sending them to the OMX decoder. BUG=136962 TEST=this runs through most of the input file displaying lots of pretty frames before segfaulting in the SEC-OMX library: DISPLAY=:0 ./Debug/omx_video_decode_accelerator_unittest --gtest_filter=DecodeVariations/VideoDecodeAcceleratorTest.TestSimpleDecode/0 --test_video_data='test-25fps.vp8:320:240:250:250:50:175:11' Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148479

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -32 lines) Patch
M content/common/gpu/media/omx_video_decode_accelerator.cc View 2 chunks +5 lines, -6 lines 1 comment Download
M content/common/gpu/media/video_decode_accelerator_unittest.cc View 5 chunks +24 lines, -26 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
Ami GONE FROM CHROMIUM
https://chromiumcodereview.appspot.com/10828022/diff/1/content/common/gpu/media/omx_video_decode_accelerator.cc File content/common/gpu/media/omx_video_decode_accelerator.cc (left): https://chromiumcodereview.appspot.com/10828022/diff/1/content/common/gpu/media/omx_video_decode_accelerator.cc#oldcode479 content/common/gpu/media/omx_video_decode_accelerator.cc:479: DCHECK_NE(current_state_change_, ERRORING); I must have been on crack when ...
8 years, 5 months ago (2012-07-25 22:41:15 UTC) #1
scherkus (not reviewing)
lgtm http://www.messletters.info/comments/congratulations/superjob.gif
8 years, 5 months ago (2012-07-26 00:00:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/10828022/1
8 years, 5 months ago (2012-07-26 00:02:09 UTC) #3
Pawel Osciak
lgtm lgtm
8 years, 5 months ago (2012-07-26 01:33:31 UTC) #4
commit-bot: I haz the power
8 years, 5 months ago (2012-07-26 02:18:01 UTC) #5
Change committed as 148479

Powered by Google App Engine
This is Rietveld 408576698