Better handling for NULL PutBytes arg in Pnacl streaming translation thread

Better handling for NULL PutBytes arg in Pnacl streaming translation thread.

Commit this instead of http://codereview.chromium.org/10834009/

R=jvoung@chromium.org,arthurhsu@chromium.org
BUG=none
TEST=nacl_integration
CID=104221

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148443

[arthurhsu, 2012-07-25 20:25:02]

On 2012/07/25 20:21:08, dschuff wrote:

LGTM

[jvoung (off chromium), 2012-07-25 20:31:42]

LGTM, can the code path be simpler when bytes is NULL though -- now there's 3
separate checks against byte != NULL?

[(google.com) Derek Schuff, 2012-07-25 21:06:39]

maybe. the problem is that we still want to set done_ even if bytes is
NULL, which means we still need to acquire the lock, etc.


On Wed, Jul 25, 2012 at 1:31 PM, <jvoung@chromium.org> wrote:

> LGTM, can the code path be simpler when bytes is NULL though -- now
> there's 3
> separate checks against byte != NULL?
>
>
https://chromiumcodereview.**appspot.com/10828019/<https://chromiumcodereview...
>

[Derek Schuff, 2012-07-25 21:30:04]

Here's another way the conditions are simpler, at the cost of duplicating the
lock sequence. Maybe still better, since it also really errors in the case that
should never happen.

[jvoung (off chromium), 2012-07-25 21:33:44]

On 2012/07/25 21:30:04, dschuff wrote:
> Here's another way the conditions are simpler, at the cost of duplicating the
> lock sequence. Maybe still better, since it also really errors in the case
that
> should never happen.

LGTM

[commit-bot: I haz the power, 2012-07-25 21:41:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dschuff@chromium.org/10828019/3

[commit-bot: I haz the power, 2012-07-25 22:58:18]

Change committed as 148443