Issue 10828013: Removed dead code in program_manager.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10828013: Removed dead code in program_manager.cc (Closed)

Created:
8 years, 5 months ago by Oren Blasberg

Modified:
8 years, 5 months ago

Reviewers:
Tyler Breisacher (Chromium)

CC:
chromium-reviews, apatrick_chromium, dmurph

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Removed dead code in program_manager.cc BUG= TEST= CID=104365 TBR=dmurph@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148390

Patch Set 2 : I'd mistakenly removed code that needed to be there. #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	gpu/command_buffer/service/program_manager.cc	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Tyler Breisacher (Chromium)

http://codereview.chromium.org/10828013/diff/1/gpu/command_buffer/service/program_manager.cc File gpu/command_buffer/service/program_manager.cc (right): http://codereview.chromium.org/10828013/diff/1/gpu/command_buffer/service/program_manager.cc#newcode83 gpu/command_buffer/service/program_manager.cc:83: index = (GLint) digit; Why are you removing the ...

8 years, 5 months ago (2012-07-25 17:47:19 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/orenb@chromium.org/10828013/3

8 years, 5 months ago (2012-07-25 17:56:27 UTC) #3

Change committed as 148390

Expand Messages | Collapse Messages

Issue 10828013: Removed dead code in program_manager.cc (Closed)

Description

Patch Set 1 #

Patch Set 2 : I'd mistakenly removed code that needed to be there. #

Messages