Issue 10828002: (Views only) Replace the content settings icons on the Website Settings UI with the new icons.

Issue 10828002: (Views only) Replace the content settings icons on the Website Settings UI with the new icons. (Closed)

Created:
8 years, 5 months ago by markusheintz_

Modified:
8 years, 5 months ago

Reviewers:
sail, oshima, battre

CC:
chromium-reviews, oshima+watch_chromium.org, Patrick Dubroy

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

(Views only) Replace the content settings icons and the dummy icons on the Website Settings UI with the set of new content settings icons. BUG=113688 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148461

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -5 lines)			Patch
	M	chrome/app/theme/theme_resources.grd	View	1 2	2 chunks	+12 lines, -0 lines	0 comments	Download
	M	chrome/browser/ui/website_settings/website_settings_ui.cc	View	1	2 chunks	+14 lines, -5 lines	0 comments	Download

Total messages: 12 (0 generated)

markusheintz_

Making Dominic the reviewer as he is in my time zone currently :-) @Dominic: Please ...

8 years, 5 months ago (2012-07-25 09:56:39 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/markusheintz@chromium.org/10828002/4001

8 years, 5 months ago (2012-07-25 17:43:35 UTC) #4

commit-bot: I haz the power

Try job failure for 10828002-4001 (retry) on mac_rel for step "runhooks". It's a second try, ...

8 years, 5 months ago (2012-07-25 17:48:49 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/markusheintz@chromium.org/10828002/4003

8 years, 5 months ago (2012-07-25 22:26:23 UTC) #6

commit-bot: I haz the power

Presubmit check for 10828002-4003 failed and returned exit status 1. Running presubmit commit checks ...

8 years, 5 months ago (2012-07-25 22:26:26 UTC) #7

markusheintz_

Adding oshima and sail for owners approval. @oshima, sail: Could one of you please review ...

8 years, 5 months ago (2012-07-25 22:35:20 UTC) #8

markusheintz_

On 2012/07/25 22:37:58, sail wrote: > lgtm > (CL description could use some clean up) ...

8 years, 5 months ago (2012-07-25 23:41:41 UTC) #10

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/markusheintz@chromium.org/10828002/4003

8 years, 5 months ago (2012-07-25 23:42:32 UTC) #11

Change committed as 148461