Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 10827456: Remove PPB_Scrollbar_Dev and PPB_Widget_Dev from native client (Closed)

Created:
8 years, 4 months ago by Josh Horwich
Modified:
8 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Remove PPB_Scrollbar_Dev and PPB_Widget_Dev from native client Native client was supporting PPB_Widget_Dev (and related PPB_Scrollbar_Dev) to support PDF Viewer. As PDF Viewer runs in-process now, this CL removes support for these interfaces from native_client. This should also let https://chromiumcodereview.appspot.com/10824386/ land without breaking nacl_integration tests BUG=140833 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152834

Patch Set 1 #

Patch Set 2 : Also remove PPB_PDF and associated tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4077 lines) Patch
M ppapi/native_client/ppapi_scons_files.py View 1 1 chunk +0 lines, -3 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/browser_globals.h View 1 4 chunks +0 lines, -6 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/browser_globals.cc View 1 3 chunks +0 lines, -21 lines 0 comments Download
D ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_pdf_rpc_server.cc View 1 1 chunk +0 lines, -253 lines 0 comments Download
D ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_scrollbar_rpc_server.cc View 1 chunk +0 lines, -160 lines 0 comments Download
D ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_widget_rpc_server.cc View 1 chunk +0 lines, -109 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/browser_ppp.cc View 3 chunks +0 lines, -10 lines 0 comments Download
D ppapi/native_client/src/shared/ppapi_proxy/browser_ppp_scrollbar.h View 1 chunk +0 lines, -27 lines 0 comments Download
D ppapi/native_client/src/shared/ppapi_proxy/browser_ppp_scrollbar.cc View 1 chunk +0 lines, -67 lines 0 comments Download
D ppapi/native_client/src/shared/ppapi_proxy/browser_ppp_widget.h View 1 chunk +0 lines, -27 lines 0 comments Download
D ppapi/native_client/src/shared/ppapi_proxy/browser_ppp_widget.cc View 1 chunk +0 lines, -53 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/build.scons View 1 3 chunks +0 lines, -5 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/nacl.scons View 1 3 chunks +0 lines, -5 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/plugin_globals.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/plugin_globals.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb.cc View 1 4 chunks +0 lines, -6 lines 0 comments Download
D ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_pdf.h View 1 1 chunk +0 lines, -26 lines 0 comments Download
D ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_pdf.cc View 1 1 chunk +0 lines, -253 lines 0 comments Download
D ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_scrollbar.h View 1 chunk +0 lines, -26 lines 0 comments Download
D ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_scrollbar.cc View 1 chunk +0 lines, -200 lines 0 comments Download
D ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_widget.h View 1 chunk +0 lines, -26 lines 0 comments Download
D ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_widget.cc View 1 chunk +0 lines, -144 lines 0 comments Download
D ppapi/native_client/src/shared/ppapi_proxy/plugin_ppp_scrollbar_rpc_server.cc View 1 chunk +0 lines, -53 lines 0 comments Download
D ppapi/native_client/src/shared/ppapi_proxy/plugin_ppp_widget_rpc_server.cc View 1 chunk +0 lines, -39 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/ppapi_proxy.gyp View 1 3 chunks +0 lines, -5 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/ppapi_proxy_untrusted.gyp View 1 3 chunks +0 lines, -5 lines 0 comments Download
D ppapi/native_client/src/shared/ppapi_proxy/ppb_pdf.srpc View 1 1 chunk +0 lines, -95 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/ppb_rpc_client.cc View 1 2 chunks +0 lines, -466 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/ppb_rpc_server.cc View 1 4 chunks +0 lines, -414 lines 0 comments Download
D ppapi/native_client/src/shared/ppapi_proxy/ppb_scrollbar.srpc View 1 chunk +0 lines, -72 lines 0 comments Download
D ppapi/native_client/src/shared/ppapi_proxy/ppb_widget.srpc View 1 chunk +0 lines, -46 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/ppp_rpc_client.cc View 2 chunks +0 lines, -54 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/ppp_rpc_server.cc View 3 chunks +0 lines, -51 lines 0 comments Download
D ppapi/native_client/src/shared/ppapi_proxy/ppp_scrollbar.srpc View 1 chunk +0 lines, -27 lines 0 comments Download
D ppapi/native_client/src/shared/ppapi_proxy/ppp_widget.srpc View 1 chunk +0 lines, -19 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/run_srpcgen.py View 1 3 chunks +0 lines, -5 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/trusted/srpcgen/ppb_rpc.h View 1 2 chunks +0 lines, -169 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/trusted/srpcgen/ppp_rpc.h View 2 chunks +0 lines, -33 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/untrusted/srpcgen/ppb_rpc.h View 1 2 chunks +0 lines, -143 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/untrusted/srpcgen/ppp_rpc.h View 2 chunks +0 lines, -36 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/plugin.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/plugin.cc View 4 chunks +0 lines, -53 lines 0 comments Download
M ppapi/native_client/tests/examples.html View 2 chunks +0 lines, -2 lines 0 comments Download
D ppapi/native_client/tests/ppapi_browser/ppb_pdf/nacl.scons View 1 1 chunk +0 lines, -45 lines 0 comments Download
D ppapi/native_client/tests/ppapi_browser/ppb_pdf/ppapi_ppb_pdf.cc View 1 1 chunk +0 lines, -258 lines 0 comments Download
D ppapi/native_client/tests/ppapi_browser/ppb_pdf/ppapi_ppb_pdf.html View 1 1 chunk +0 lines, -29 lines 0 comments Download
D ppapi/native_client/tests/ppapi_browser/ppb_pdf/ppapi_ppb_pdf.js View 1 1 chunk +0 lines, -46 lines 0 comments Download
D ppapi/native_client/tests/ppapi_browser/ppb_scrollbar/nacl.scons View 1 chunk +0 lines, -39 lines 0 comments Download
D ppapi/native_client/tests/ppapi_browser/ppb_scrollbar/ppapi_ppb_scrollbar.cc View 1 chunk +0 lines, -145 lines 0 comments Download
D ppapi/native_client/tests/ppapi_browser/ppb_scrollbar/ppapi_ppb_scrollbar.html View 1 chunk +0 lines, -29 lines 0 comments Download
D ppapi/native_client/tests/ppapi_browser/ppb_scrollbar/ppapi_ppb_scrollbar.js View 1 chunk +0 lines, -40 lines 0 comments Download
D ppapi/native_client/tests/ppapi_browser/ppb_widget/nacl.scons View 1 chunk +0 lines, -39 lines 0 comments Download
D ppapi/native_client/tests/ppapi_browser/ppb_widget/ppapi_ppb_widget.cc View 1 chunk +0 lines, -93 lines 0 comments Download
D ppapi/native_client/tests/ppapi_browser/ppb_widget/ppapi_ppb_widget.html View 1 chunk +0 lines, -29 lines 0 comments Download
D ppapi/native_client/tests/ppapi_browser/ppb_widget/ppapi_ppb_widget.js View 1 chunk +0 lines, -36 lines 0 comments Download
M ppapi/native_client/tests/ppapi_test_lib/get_browser_interface.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ppapi/native_client/tests/ppapi_test_lib/get_browser_interface.cc View 3 chunks +0 lines, -14 lines 0 comments Download
M ppapi/native_client/tests/ppapi_tests/nacl.scons View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Josh Horwich
Bill, Please take a look. After discussions with brettw and ncbray I removed support in ...
8 years, 4 months ago (2012-08-21 22:57:51 UTC) #1
bbudge
LGTM
8 years, 4 months ago (2012-08-21 23:43:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jhorwich@chromium.org/10827456/6001
8 years, 4 months ago (2012-08-22 15:54:20 UTC) #3
commit-bot: I haz the power
Try job failure for 10827456-6001 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-22 17:22:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jhorwich@chromium.org/10827456/6001
8 years, 4 months ago (2012-08-22 19:20:27 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-22 21:56:21 UTC) #6
Change committed as 152834

Powered by Google App Engine
This is Rietveld 408576698