Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 10827411: Disable uses of URLBlacklist on platforms that don't support it. (Closed)

Created:
8 years, 4 months ago by Philippe
Modified:
8 years, 4 months ago
CC:
chromium-reviews, Ted C, David Trainor- moved to gerrit
Visibility:
Public.

Description

Disable uses of URLBlacklist on platforms that don't support it. This was causing linking issues on the Linux Redux bot. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152396

Patch Set 1 #

Patch Set 2 : Fix unused variable error #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/managed_mode_url_filter.cc View 1 2 3 2 chunks +2 lines, -0 lines 3 comments Download

Messages

Total messages: 13 (0 generated)
Philippe
8 years, 4 months ago (2012-08-20 10:07:42 UTC) #1
Nico
8 years, 4 months ago (2012-08-20 14:20:12 UTC) #2
Joao da Silva
https://chromiumcodereview.appspot.com/10827411/diff/10001/chrome/browser/managed_mode_url_filter.cc File chrome/browser/managed_mode_url_filter.cc (right): https://chromiumcodereview.appspot.com/10827411/diff/10001/chrome/browser/managed_mode_url_filter.cc#newcode37 chrome/browser/managed_mode_url_filter.cc:37: if (!policy::URLBlacklist::FilterToComponents( This is probably what causes the problem, ...
8 years, 4 months ago (2012-08-20 14:41:03 UTC) #3
Bernhard Bauer
https://chromiumcodereview.appspot.com/10827411/diff/10001/chrome/browser/managed_mode_url_filter.cc File chrome/browser/managed_mode_url_filter.cc (right): https://chromiumcodereview.appspot.com/10827411/diff/10001/chrome/browser/managed_mode_url_filter.cc#newcode37 chrome/browser/managed_mode_url_filter.cc:37: if (!policy::URLBlacklist::FilterToComponents( On 2012/08/20 14:41:03, Joao da Silva wrote: ...
8 years, 4 months ago (2012-08-20 14:48:05 UTC) #4
Joao da Silva
https://chromiumcodereview.appspot.com/10827411/diff/10001/chrome/browser/managed_mode_url_filter.cc File chrome/browser/managed_mode_url_filter.cc (right): https://chromiumcodereview.appspot.com/10827411/diff/10001/chrome/browser/managed_mode_url_filter.cc#newcode37 chrome/browser/managed_mode_url_filter.cc:37: if (!policy::URLBlacklist::FilterToComponents( On 2012/08/20 14:48:05, Bernhard Bauer wrote: > ...
8 years, 4 months ago (2012-08-20 14:58:16 UTC) #5
Philippe
On 2012/08/20 14:58:16, Joao da Silva wrote: > https://chromiumcodereview.appspot.com/10827411/diff/10001/chrome/browser/managed_mode_url_filter.cc > File chrome/browser/managed_mode_url_filter.cc (right): > > ...
8 years, 4 months ago (2012-08-20 16:12:08 UTC) #6
Bernhard Bauer
On 2012/08/20 16:12:08, Philippe wrote: > On 2012/08/20 14:58:16, Joao da Silva wrote: > > ...
8 years, 4 months ago (2012-08-20 16:35:05 UTC) #7
Philippe
On 2012/08/20 16:35:05, Bernhard Bauer wrote: > On 2012/08/20 16:12:08, Philippe wrote: > > On ...
8 years, 4 months ago (2012-08-20 16:41:31 UTC) #8
Bernhard Bauer
On 2012/08/20 16:41:31, Philippe wrote: > On 2012/08/20 16:35:05, Bernhard Bauer wrote: > > On ...
8 years, 4 months ago (2012-08-20 16:42:19 UTC) #9
Nico
lgtm stamp from me too then.
8 years, 4 months ago (2012-08-20 16:43:26 UTC) #10
Philippe
On 2012/08/20 16:43:26, Nico wrote: > lgtm stamp from me too then. Thanks guys!
8 years, 4 months ago (2012-08-20 16:44:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/10827411/10001
8 years, 4 months ago (2012-08-20 16:45:04 UTC) #12
commit-bot: I haz the power
8 years, 4 months ago (2012-08-20 22:10:21 UTC) #13
Change committed as 152396

Powered by Google App Engine
This is Rietveld 408576698