Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 10827404: The password manager infobar is suppressed when the one-click infobar is (Closed)

Created:
8 years, 4 months ago by Roger Tawa OOO till Jul 10th
Modified:
8 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

The password manager infobar is suppressed when the one-click infobar is supposed to show itself. However, in this case the problem was that the later was not showing. The problem is that the one-click infobar triggers on the http header "Google-Accounts-Signin", which it was looking in the headers of 302 redirect responses, but in some cases it can also appear in 200 responses. BUG=132849 TEST=Make sure that the one-click infobar is always shown in the right conditions. I'm not sure how to trigger a sign in without all the redirects. I was only able to repro this bug on on Windows XP machine. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152405

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 1 chunk +8 lines, -0 lines 2 comments Download

Messages

Total messages: 10 (0 generated)
Roger Tawa OOO till Jul 10th
Hi Tim, Please take a look. Thanks.
8 years, 4 months ago (2012-08-17 19:30:55 UTC) #1
tim (not reviewing)
http://codereview.chromium.org/10827404/diff/1/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc File chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc (right): http://codereview.chromium.org/10827404/diff/1/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc#newcode346 chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc:346: #if defined(ENABLE_ONE_CLICK_SIGNIN) How come we're still using an ifdef ...
8 years, 4 months ago (2012-08-17 19:43:14 UTC) #2
Roger Tawa OOO till Jul 10th
http://codereview.chromium.org/10827404/diff/1/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc File chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc (right): http://codereview.chromium.org/10827404/diff/1/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc#newcode346 chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc:346: #if defined(ENABLE_ONE_CLICK_SIGNIN) On 2012/08/17 19:43:14, timsteele wrote: > How ...
8 years, 4 months ago (2012-08-17 20:09:43 UTC) #3
tim (not reviewing)
Ah, thanks for explaining! LGTM
8 years, 4 months ago (2012-08-17 20:11:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/10827404/1
8 years, 4 months ago (2012-08-20 13:48:02 UTC) #5
commit-bot: I haz the power
Presubmit check for 10827404-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-20 13:48:04 UTC) #6
Roger Tawa OOO till Jul 10th
Hi Brett, Can you do an owner review please. Thanks.
8 years, 4 months ago (2012-08-20 13:56:02 UTC) #7
brettw
lgtm
8 years, 4 months ago (2012-08-20 17:22:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/10827404/1
8 years, 4 months ago (2012-08-20 17:50:44 UTC) #9
commit-bot: I haz the power
8 years, 4 months ago (2012-08-20 22:18:36 UTC) #10
Change committed as 152405

Powered by Google App Engine
This is Rietveld 408576698