Issue 10827395: Convert find_in_page.py pyauto test to a browser_test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10827395: Convert find_in_page.py pyauto test to a browser_test (Closed)

Created:
8 years, 4 months ago by jam

Modified:
8 years, 4 months ago

Reviewers:
sky

CC:
chromium-reviews, Nirnimesh, tfarina, anantha, dyu1, brettw-cc_chromium.org, dennis_jeffrey

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Convert find_in_page.py pyauto test to a browser_test. I skipped test cases that were duplicated in existing tests (i.e. pdf searching which is already in pdf_browsertest.cc, and basic searching\case-sensitive). I converted the looping and timing to instead hop to the history thread and back, which should make things less flaky. BUG=143637 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152329

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+225 lines, -262 lines)			Patch
M	chrome/browser/ui/find_bar/find_bar_host_browsertest.cc	View	1 2	6 chunks	+225 lines, -10 lines	0 comments	Download
M	chrome/test/functional/PYAUTO_TESTS	View	1	2 chunks	+0 lines, -3 lines	0 comments	Download
M	chrome/test/functional/find_in_page.py	View	1	1 chunk	+0 lines, -249 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages