Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 10827384: Mark Tulip as flaky on Mac. (Closed)

Created:
8 years, 4 months ago by DaleCurtis
Modified:
8 years, 4 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Mark Tulip as flaky on Mac. Tulip was incorrectly marked flaky on all platforms due to an issue where #define and TEST_P don't interact well (see issue 143151). Also cleans up the disabled Flac test to use proper DISABLED_ syntax instead of being commented out. BUG=141020, 142896 TEST=media_browsertests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152165

Patch Set 1 : Rebase. #

Patch Set 2 : Keep flac test disabled :-/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M content/browser/media_browsertest.cc View 1 2 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
DaleCurtis
PTAL. Re: our discussion this morning.
8 years, 4 months ago (2012-08-17 03:13:23 UTC) #1
jam
lgtm
8 years, 4 months ago (2012-08-17 16:42:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/10827384/9002
8 years, 4 months ago (2012-08-17 17:45:18 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-17 22:34:38 UTC) #4
Change committed as 152165

Powered by Google App Engine
This is Rietveld 408576698