Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 10827377: Adds an interface between WorkspaceController and (Closed)

Created:
8 years, 4 months ago by sky
Modified:
8 years, 4 months ago
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Adds an interface between WorkspaceController and WorkspaceManager. This will allow introducing different behavior. BUG=137342 TEST=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151939

Patch Set 1 #

Patch Set 2 : Add virtual & OVERRIDE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -64 lines) Patch
M ash/ash.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/stacking_controller.cc View 1 chunk +1 line, -2 lines 0 comments Download
A ash/wm/workspace/base_workspace_manager.h View 1 chunk +50 lines, -0 lines 0 comments Download
M ash/wm/workspace/workspace_manager.h View 1 4 chunks +14 lines, -28 lines 0 comments Download
M ash/wm/workspace/workspace_manager.cc View 1 3 chunks +37 lines, -25 lines 0 comments Download
M ash/wm/workspace_controller.h View 3 chunks +8 lines, -2 lines 0 comments Download
M ash/wm/workspace_controller.cc View 3 chunks +18 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sky
8 years, 4 months ago (2012-08-16 15:33:47 UTC) #1
Ben Goodger (Google)
8 years, 4 months ago (2012-08-16 17:07:17 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698