Issue 10827368: ash: Avoid implicit conversion from ImageSkia into SkBitmap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10827368: ash: Avoid implicit conversion from ImageSkia into SkBitmap. (Closed)

Created:
8 years, 4 months ago by sadrul

Modified:
8 years, 4 months ago

Reviewers:
sky

CC:
chromium-reviews, stevenjb+watch_chromium.org, sadrul, oshima+watch_chromium.org, ben+watch_chromium.org, bshe, pkotwicz

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

ash: Avoid implicit conversion from ImageSkia into SkBitmap. BUG=141146 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151902

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -16 lines)			Patch
M	ash/desktop_background/desktop_background_controller.h	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	ash/desktop_background/desktop_background_controller.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ash/launcher/tabbed_launcher_button.h	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	ash/launcher/tabbed_launcher_button.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/options2/chromeos/wallpaper_source.cc	View	1 chunk	+7 lines, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

sadrul

We are incrementally getting rid of implicit ImageSkia -> SkBitmap conversions. This CL gets rid ...

8 years, 4 months ago (2012-08-16 01:55:09 UTC) #1

LGTM