Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1401)

Unified Diff: vm/symbols.cc

Issue 10827367: 1. Fix an issue with VM class names being null (this is exposed when doing a heap profile) (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/symbols.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/symbols.cc
===================================================================
--- vm/symbols.cc (revision 10842)
+++ vm/symbols.cc (working copy)
@@ -41,7 +41,7 @@
ASSERT((sizeof(names) / sizeof(const char*)) == Symbols::kMaxId);
const Array& symbol_table =
Array::Handle(isolate->object_store()->symbol_table());
- OneByteString& str = OneByteString::Handle();
+ dart::OneByteString& str = OneByteString::Handle();
for (intptr_t i = 1; i < Symbols::kMaxId; i++) {
str = OneByteString::New(names[i], Heap::kOld);
@@ -71,7 +71,7 @@
Array& symbol_table = Array::Handle(isolate,
isolate->object_store()->symbol_table());
intptr_t table_size_index = symbol_table.Length() - 1;
- Smi& used = Smi::Handle();
+ dart::Smi& used = Smi::Handle();
used ^= symbol_table.At(table_size_index);
return used.Value();
}
@@ -203,7 +203,7 @@
// Copy all elements from the original symbol table to the newly allocated
// array.
String& element = String::Handle();
- Object& new_element = Object::Handle();
+ dart::Object& new_element = Object::Handle();
for (intptr_t i = 0; i < table_size; i++) {
element ^= symbol_table.At(i);
if (!element.IsNull()) {
@@ -231,7 +231,7 @@
intptr_t table_size = symbol_table.Length() - 1;
symbol.SetCanonical(); // Mark object as being canonical.
symbol_table.SetAt(index, symbol); // Remember the new symbol.
- Smi& used = Smi::Handle();
+ dart::Smi& used = Smi::Handle();
used ^= symbol_table.At(table_size);
intptr_t used_elements = used.Value() + 1; // One more element added.
used = Smi::New(used_elements);
« no previous file with comments | « vm/symbols.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698