Fix ChromeDriver flakiness with the C# webdriver bindings.

Fix ChromeDriver flakiness with the C# webdriver bindings.

Since keep-alive was disabled in r142538, C# webdriver tests have been failing
occassionally saying no response was sent from chromedriver. This is because
the .NET HttpWebRequest throws an exception when the server closes a connection
without specifying Connection:close. This was reproducible on slower machines.

This change refactors the http response process to funnel all responses through
WriteHttpResponse, which adds the Connection:close header when appropriate.
BUG=chromedriver:121
TEST=none
TBR=ben

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152227

[dennis_jeffrey, 2012-08-16 01:17:13]

a question and some nits

http://codereview.chromium.org/10827362/diff/1010/chrome/test/webdriver/http_...
File chrome/test/webdriver/http_response.cc (right):

http://codereview.chromium.org/10827362/diff/1010/chrome/test/webdriver/http_...
chrome/test/webdriver/http_response.cc:1: // Copyright (c) 2011 The Chromium
Authors. All rights reserved.
2011 --> 2012

http://codereview.chromium.org/10827362/diff/1010/chrome/test/webdriver/http_...
File chrome/test/webdriver/http_response.h (left):

http://codereview.chromium.org/10827362/diff/1010/chrome/test/webdriver/http_...
chrome/test/webdriver/http_response.h:75:
DISALLOW_COPY_AND_ASSIGN(HttpResponse);
why was this removed?

http://codereview.chromium.org/10827362/diff/1010/chrome/test/webdriver/http_...
File chrome/test/webdriver/http_response.h (right):

http://codereview.chromium.org/10827362/diff/1010/chrome/test/webdriver/http_...
chrome/test/webdriver/http_response.h:1: // Copyright (c) 2011 The Chromium
Authors. All rights reserved.
2011 --> 2012

http://codereview.chromium.org/10827362/diff/1010/chrome/test/webdriver/http_...
File chrome/test/webdriver/http_response_unittest.cc (right):

http://codereview.chromium.org/10827362/diff/1010/chrome/test/webdriver/http_...
chrome/test/webdriver/http_response_unittest.cc:1: // Copyright (c) 2011 The
Chromium Authors. All rights reserved.
2011 --> 2012

http://codereview.chromium.org/10827362/diff/1010/chrome/test/webdriver/webdr...
File chrome/test/webdriver/webdriver_dispatch_unittest.cc (right):

http://codereview.chromium.org/10827362/diff/1010/chrome/test/webdriver/webdr...
chrome/test/webdriver/webdriver_dispatch_unittest.cc:1: // Copyright (c) 2011
The Chromium Authors. All rights reserved.
2011 --> 2012

[kkania, 2012-08-16 16:49:34]

http://codereview.chromium.org/10827362/diff/1010/chrome/test/webdriver/http_...
File chrome/test/webdriver/http_response.h (left):

http://codereview.chromium.org/10827362/diff/1010/chrome/test/webdriver/http_...
chrome/test/webdriver/http_response.h:75:
DISALLOW_COPY_AND_ASSIGN(HttpResponse);
On 2012/08/16 01:17:13, dennis_jeffrey wrote:
> why was this removed?

Because I want to copy it in WriteHttpResponse.

http://codereview.chromium.org/10827362/diff/1010/chrome/test/webdriver/http_...
File chrome/test/webdriver/http_response.h (right):

http://codereview.chromium.org/10827362/diff/1010/chrome/test/webdriver/http_...
chrome/test/webdriver/http_response.h:1: // Copyright (c) 2011 The Chromium
Authors. All rights reserved.
On 2012/08/16 01:17:13, dennis_jeffrey wrote:
> 2011 --> 2012

You no longer have to modify the year:
https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-de...

[dennis_jeffrey, 2012-08-16 17:27:07]

LGTM

http://codereview.chromium.org/10827362/diff/1010/chrome/test/webdriver/http_...
File chrome/test/webdriver/http_response.h (right):

http://codereview.chromium.org/10827362/diff/1010/chrome/test/webdriver/http_...
chrome/test/webdriver/http_response.h:1: // Copyright (c) 2011 The Chromium
Authors. All rights reserved.
On 2012/08/16 16:49:34, kkania wrote:
> On 2012/08/16 01:17:13, dennis_jeffrey wrote:
> > 2011 --> 2012
> 
> You no longer have to modify the year:
>
https://groups.google.com/a/chromium.org/forum/?fromgroups#%21topic/chromium-...

Good to know - thanks for the link!

[kkania, 2012-08-17 23:45:29]

adding Ben for chrome/chrome.gypi

[kkania, 2012-08-17 23:45:40]

On 2012/08/17 23:45:29, kkania wrote:
> adding Ben for chrome/chrome.gypi

oops, i mean chrome/chrome_tests.gypi

[commit-bot: I haz the power, 2012-08-18 00:48:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kkania@chromium.org/10827362/4003

[commit-bot: I haz the power, 2012-08-18 02:58:35]

Change committed as 152227

[Ben Goodger (Google), 2012-08-20 17:15:19]

lgtm