Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(965)

Issue 10827357: Add NaCl smoke test to browser_tests. (Closed)

Created:
8 years, 4 months ago by Nick Bray (chromium)
Modified:
8 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews, native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Add NaCl smoke test to browser_tests. The smoke test is simple - it checks that Chrome can load nexes. The more interesting part of this CL is that it lays the groundwork for adding more NaCl tests to browser_tests. This will allow many nacl_integration tests to be rewritten as browser_tests. This CL adds an extensible jig for decoding messages from Javascript, which makes it easier to add test logic in the web page. This CL also establishes locations in the build directory for nexes and other test data. There are two followup CLs planned: 1) simplify how nexes are built in GYP and 2) share the code for running tests in Javascript with the PPAPI test suite. This is a recommit of r151716 with Linux ASAN tests disabled and GYP tweaks for VS2010. BUG= http://code.google.com/p/nativeclient/issues/detail?id=2959 TEST= browser_tests --gtest_filter=NaClBrowserTest* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151963

Patch Set 1 #

Patch Set 2 : VS2010 fix? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+562 lines, -43 lines) Patch
M chrome/chrome_tests.gypi View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/test/base/ui_test_utils.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/test/base/ui_test_utils.cc View 2 chunks +43 lines, -0 lines 0 comments Download
A chrome/test/data/nacl/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/test/data/nacl/OWNERS View 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/test/data/nacl/nacl_load_test.html View 1 chunk +41 lines, -0 lines 0 comments Download
A chrome/test/data/nacl/nacl_test_data.gyp View 1 1 chunk +112 lines, -0 lines 0 comments Download
A chrome/test/data/nacl/simple.cc View 1 chunk +27 lines, -0 lines 0 comments Download
A chrome/test/nacl/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/test/nacl/nacl_browsertest.cc View 1 chunk +317 lines, -0 lines 0 comments Download
M chrome/test/ppapi/ppapi_test.cc View 3 chunks +3 lines, -42 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nick Bray (chromium)
Here's a re-spin of the CL you reverted. All that has changed is an ifdef ...
8 years, 4 months ago (2012-08-16 16:53:22 UTC) #1
brettw
8 years, 4 months ago (2012-08-16 20:18:52 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698