Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 10827356: Revert 151716 - Add NaCl smoke test to browser_tests. (Closed)

Created:
8 years, 4 months ago by brettw
Modified:
8 years, 4 months ago
CC:
chromium-reviews, native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Revert 151716 - Add NaCl smoke test to browser_tests. The new test fails on some bots: http://build.chromium.org/p/chromium.memory/builders/Chromium%20OS%20ASAN%20Tests%20%281%29/builds/992/steps/browser_tests/logs/stdio http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Tests%20%281%29/builds/1195/steps/browser_tests/logs/stdio The smoke test is simple - it checks that Chrome can load nexes. The more interesting part of this CL is that it lays the groundwork for adding more NaCl tests to browser_tests. This will allow many nacl_integration tests to be rewritten as browser_tests. This CL adds an extensible jig for decoding messages from Javascript, which makes it easier to add test logic in the web page. This CL also establishes locations in the build directory for nexes and other test data. There are two followup CLs planned: 1) simplify how nexes are built in GYP and 2) share the code for running tests in Javascript with the PPAPI test suite. BUG= http://code.google.com/p/nativeclient/issues/detail?id=2959 TEST= browser_tests --gtest_filter=NaClBrowserTest* Review URL: https://chromiumcodereview.appspot.com/10837207 TBR=ncbray@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151724

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -551 lines) Patch
MM chrome/chrome_tests.gypi View 1 chunk +1 line, -5 lines 0 comments Download
MM chrome/test/base/ui_test_utils.h View 1 chunk +0 lines, -3 lines 0 comments Download
MM chrome/test/base/ui_test_utils.cc View 2 chunks +0 lines, -43 lines 0 comments Download
D chrome/test/data/nacl/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/test/data/nacl/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/test/data/nacl/nacl_load_test.html View 1 chunk +0 lines, -41 lines 0 comments Download
D chrome/test/data/nacl/nacl_test_data.gyp View 1 chunk +0 lines, -108 lines 0 comments Download
D chrome/test/data/nacl/simple.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/test/nacl/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/test/nacl/nacl_browsertest.cc View 1 chunk +0 lines, -310 lines 0 comments Download
M chrome/test/ppapi/ppapi_test.cc View 3 chunks +42 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
8 years, 4 months ago (2012-08-15 19:26:44 UTC) #1
Nick Bray (chromium)
8 years, 4 months ago (2012-08-16 16:54:18 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698