Split out gdata_directory_service*

Split out gdata_directory_service*

* Move GDataDirectoryService declaration, definition and related classes, structs, constants, etc to gdata_directory_service.h, .cc.
* Split unit test into gdata_directory_service_unittest.cc
* For now, gdata_directory_service.h includes gdata_files.h. Change all includes of gdata_files.h to include gdata_directory_service.h instead. Very soon, gdata_files.h will be removed from gdata_directory_service.h, and only included as needed. We will eventually deprecate gdata_files.h/.cc entirely and use GDataEntryProto and friends.
* Some #includes are redundant. These will be sorted out in a future patch.

BUG=140317
TEST=compiles.
TBR=ben@chromium.org (for gypi changes)
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151747

[achuithb, 2012-08-15 19:44:01]

Please review, Satoru-san.

I'd like to land this sooner rather than later due to the difficulty of merging
TOT with this patch.

[satorux1, 2012-08-15 20:29:28]

just code moves, no semantic changes, right?

[achuithb, 2012-08-15 20:31:39]

On 2012/08/15 20:29:28, satorux1 wrote:
> just code moves, no semantic changes, right?

Actually I snuck in some changes I knew you wouldn't approve of. Removing
function comments, and messing up the indentation.

j/k - no code changes.

[satorux1, 2012-08-15 20:34:11]

Thank you for doing this! LGTM

http://codereview.chromium.org/10827343/diff/17/chrome/browser/chromeos/gdata...
File chrome/browser/chromeos/gdata/gdata_directory_service.h (right):

http://codereview.chromium.org/10827343/diff/17/chrome/browser/chromeos/gdata...
chrome/browser/chromeos/gdata/gdata_directory_service.h:102: class
GDataDirectoryService {
not in this patch, but we should probably rename this class, like
DriveResourceMetadata or something. do you have any ideas?

[achuithb, 2012-08-15 20:38:24]

http://codereview.chromium.org/10827343/diff/17/chrome/browser/chromeos/gdata...
File chrome/browser/chromeos/gdata/gdata_directory_service.h (right):

http://codereview.chromium.org/10827343/diff/17/chrome/browser/chromeos/gdata...
chrome/browser/chromeos/gdata/gdata_directory_service.h:102: class
GDataDirectoryService {
On 2012/08/15 20:34:11, satorux1 wrote:
> not in this patch, but we should probably rename this class, like
> DriveResourceMetadata or something. do you have any ideas?

GDataResourceMetadata? I think we should continue to use GData for consistency
unless we want to do 
s/GData/Drive
which will be quite painful.

[satorux1, 2012-08-15 20:40:48]

please submit this asap :)

http://codereview.chromium.org/10827343/diff/17/chrome/browser/chromeos/gdata...
File chrome/browser/chromeos/gdata/gdata_directory_service.h (right):

http://codereview.chromium.org/10827343/diff/17/chrome/browser/chromeos/gdata...
chrome/browser/chromeos/gdata/gdata_directory_service.h:102: class
GDataDirectoryService {
On 2012/08/15 20:38:24, achuith.bhandarkar wrote:
> On 2012/08/15 20:34:11, satorux1 wrote:
> > not in this patch, but we should probably rename this class, like
> > DriveResourceMetadata or something. do you have any ideas?
> 
> GDataResourceMetadata? I think we should continue to use GData for consistency
> unless we want to do 
> s/GData/Drive
> which will be quite painful.

s/GData/Drive/ is planned for Drive specific code, and will happen! :)

[achuithb, 2012-08-15 20:50:52]

On 2012/08/15 20:40:48, satorux1 wrote:
> please submit this asap :)

Had to rebase after all, just want to make sure stuff still builds!

[achuithb, 2012-08-15 21:12:09]

Ben: minor gypi change, have TBR'd you. Please take a look when you have a
moment.

[Ben Goodger (Google), 2012-08-16 17:55:59]

lgtm