Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 10827342: Reduce per-tab memory to 128M maximum, reduce default maximum across all tabs to 256M (Closed)

Created:
8 years, 4 months ago by ccameron
Modified:
8 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, Vangelis Kokkevis
Visibility:
Public.

Description

Reduce per-tab memory to 128M maximum, reduce default maximum across all tabs to 256M. The more appropriate fix is that we should be more aggressively discarding offscreen tiles, but this will temporarily fix some OOM issues that we're encountering on low-FB parts. BUG=141377 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151778

Patch Set 1 #

Patch Set 2 : Actually drop the limit to 256MB #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -6 lines) Patch
M content/common/gpu/gpu_memory_manager.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/common/gpu/gpu_memory_manager.cc View 1 3 chunks +6 lines, -2 lines 0 comments Download
M content/common/gpu/gpu_memory_manager_unittest.cc View 1 5 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
ccameron
8 years, 4 months ago (2012-08-15 01:03:00 UTC) #1
Ken Russell (switch to Gerrit)
The code LGTM but this needs thorough manual testing.
8 years, 4 months ago (2012-08-15 01:15:24 UTC) #2
ccameron
On 2012/08/15 01:15:24, kbr wrote: > The code LGTM but this needs thorough manual testing. ...
8 years, 4 months ago (2012-08-15 18:36:18 UTC) #3
nduca
Remind me what happens content goes over? We dont draw the tiles?
8 years, 4 months ago (2012-08-15 18:42:28 UTC) #4
ccameron
On 2012/08/15 18:42:28, nduca wrote: > Remind me what happens content goes over? We dont ...
8 years, 4 months ago (2012-08-15 18:45:33 UTC) #5
nduca
(LGTm fwiw, just trying to remind myself what happens when we get this wrong.)
8 years, 4 months ago (2012-08-15 18:49:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/10827342/2001
8 years, 4 months ago (2012-08-15 21:12:14 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-15 23:06:42 UTC) #8
Change committed as 151778

Powered by Google App Engine
This is Rietveld 408576698