editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisUtility.java - Issue 10827339: Issue 4460. Mark inferred type variable in for-in loop as inferred

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisUtility.java

Issue 10827339: Issue 4460. Mark inferred type variable in for-in loop as inferred (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java ('k') | editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/compiler/DartCompilerUtilities.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisUtility.java

diff --git a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisUtility.java b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisUtility.java

index ad2713138879e58b2e3c6e32e1671088ab1d4ffc..33b2f8d0fb48f5e1d1caedd68e0296cc6dd52fac 100644

--- a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisUtility.java

+++ b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisUtility.java

@@ -13,7 +13,6 @@

package com.google.dart.tools.core.analysis;

-import com.google.dart.compiler.CommandLineOptions.CompilerOptions;

import com.google.dart.compiler.CompilerConfiguration;

import com.google.dart.compiler.DartCompilationError;

import com.google.dart.compiler.DartCompiler.SelectiveCache;

@@ -47,14 +46,7 @@ import java.util.Set;

class AnalysisUtility {

private static final CompilerConfiguration config = new DefaultCompilerConfiguration(

- new CompilerOptions() {

- @Override

- public boolean memberWarningForInferredTypes() {

- return DartCore.getPlugin().getPrefs().getBoolean(

- DartCore.MEMBER_WARNING_FOR_INFERRED_TYPES,

- false);

- }

- },

+ DartCompilerUtilities.COMPILER_OPTIONS,

SystemLibraryManagerProvider.getSystemLibraryManager()) {

@Override

public boolean incremental() {