Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: Source/WebCore/html/shadow/MediaControlRootElementChromium.h

Issue 10827333: Merge 123822 - [Chromium] Regression: Global-buffer-overflow in WebCore::mediaControlElementType (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1180/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/WebCore/html/shadow/MediaControlRootElementChromium.h
===================================================================
--- Source/WebCore/html/shadow/MediaControlRootElementChromium.h (revision 125606)
+++ Source/WebCore/html/shadow/MediaControlRootElementChromium.h (working copy)
@@ -29,6 +29,7 @@
#if ENABLE(VIDEO)
+#include "MediaControlElements.h"
#include "MediaControls.h"
#include <wtf/RefPtr.h>
@@ -61,22 +62,15 @@
class MediaControlTextTrackDisplayElement;
#endif
-class MediaControlChromiumEnclosureElement : public HTMLDivElement {
+class MediaControlChromiumEnclosureElement : public MediaControlElement {
public:
static PassRefPtr<MediaControlChromiumEnclosureElement> create(Document*);
- virtual const AtomicString& shadowPseudoId() const;
-
- void setMediaController(MediaControllerInterface* controller) { m_mediaController = controller; }
- MediaControllerInterface* mediaController() const { return m_mediaController; }
-
-protected:
- MediaControlChromiumEnclosureElement(Document*);
-
private:
- virtual bool isMediaControlElement() const { return true; }
+ explicit MediaControlChromiumEnclosureElement(Document*);
- MediaControllerInterface* m_mediaController;
+ virtual MediaControlElementType displayType() const;
+ virtual const AtomicString& shadowPseudoId() const;
};
class MediaControlRootElementChromium : public MediaControls {
« no previous file with comments | « LayoutTests/accessibility/media-controls-expected.txt ('k') | Source/WebCore/html/shadow/MediaControlRootElementChromium.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698