Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: chrome/browser/chromeos/version_loader.h

Issue 10827322: Set linux distro to CHROMEOS_RELEASE_DESCRIPTION on ChromeOS (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge with trunk and switch to const-ref string params in version loader callbacks Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/version_loader.h
diff --git a/chrome/browser/chromeos/version_loader.h b/chrome/browser/chromeos/version_loader.h
index 001a20e65ca919aacf78bd67ff1ebace3e1575f8..9f156190d725cfd27ee5a9d252943d6bb3aae57e 100644
--- a/chrome/browser/chromeos/version_loader.h
+++ b/chrome/browser/chromeos/version_loader.h
@@ -23,7 +23,7 @@ namespace chromeos {
// CancelableRequestConsumerBase.
// . Define the callback method, something like:
// void OnGetChromeOSVersion(chromeos::VersionLoader::Handle,
-// std::string version);
+// const std::string& version);
// . When you want the version invoke: loader.GetVersion(&consumer, callback);
//
// This class also provides the ability to load the bios firmware using
@@ -40,10 +40,10 @@ class VersionLoader : public CancelableRequestProvider {
};
// Signature
- typedef base::Callback<void(Handle, std::string)> GetVersionCallback;
+ typedef base::Callback<void(Handle, const std::string&)> GetVersionCallback;
typedef CancelableRequest<GetVersionCallback> GetVersionRequest;
- typedef base::Callback<void(Handle, std::string)> GetFirmwareCallback;
+ typedef base::Callback<void(Handle, const std::string&)> GetFirmwareCallback;
typedef CancelableRequest<GetFirmwareCallback> GetFirmwareRequest;
// Asynchronously requests the version.
« no previous file with comments | « chrome/browser/chromeos/login/version_info_updater.cc ('k') | chrome/browser/policy/device_status_collector.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698