Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 10827317: Refleshes display info when the chrome://settings/display dialog gets visible. (Closed)

Created:
8 years, 4 months ago by Jun Mukai
Modified:
8 years, 4 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, arv (Not doing code reviews), stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Refleshes display info when the chrome://settings/display dialog gets visible. We should re-calculate the display layouts on the visibility change timing, since it depends on the frame size which would be empty when invisible. BUG=142055 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/resources/options2/chromeos/display_options.js View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jun Mukai
8 years, 4 months ago (2012-08-14 11:46:04 UTC) #1
James Hawkins
lgtm
8 years, 4 months ago (2012-08-14 14:15:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/10827317/1
8 years, 4 months ago (2012-08-14 15:12:31 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-14 19:25:50 UTC) #4
Change committed as 151538

Powered by Google App Engine
This is Rietveld 408576698