Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10827314: Revert 151351 - Replace the DownloadFileManager with direct ownership (Closed)

Created:
8 years, 4 months ago by Yuta Kitamura
Modified:
8 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, rginda+watch_chromium.org, jam, rdsmith+dwatch_chromium.org
Visibility:
Public.

Description

Revert 151351 - Replace the DownloadFileManager with direct ownership of DownloadFileImpl by DownloadItemImpl. BUG=123998 R=benjhayden@chromium.org Review URL: https://chromiumcodereview.appspot.com/10799005 TBR=rdsmith@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151443

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+819 lines, -1007 lines) Patch
M chrome/browser/download/download_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/browser_context.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/browser_main_loop.cc View 2 chunks +4 lines, -1 line 0 comments Download
M content/browser/download/base_file.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/download/base_file.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/download/download_file.h View 4 chunks +11 lines, -13 lines 0 comments Download
D content/browser/download/download_file_factory.h View 1 chunk +0 lines, -44 lines 0 comments Download
D content/browser/download/download_file_factory.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M content/browser/download/download_file_impl.h View 5 chunks +25 lines, -22 lines 0 comments Download
M content/browser/download/download_file_impl.cc View 8 chunks +64 lines, -65 lines 0 comments Download
A + content/browser/download/download_file_manager.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/download/download_file_manager.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/download/download_file_manager_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/browser/download/download_file_unittest.cc View 16 chunks +83 lines, -66 lines 0 comments Download
M content/browser/download/download_item_impl.h View 9 chunks +16 lines, -38 lines 0 comments Download
M content/browser/download/download_item_impl.cc View 14 chunks +36 lines, -170 lines 0 comments Download
M content/browser/download/download_item_impl_delegate.h View 1 chunk +2 lines, -12 lines 0 comments Download
M content/browser/download/download_item_impl_delegate.cc View 2 chunks +4 lines, -9 lines 0 comments Download
M content/browser/download/download_item_impl_unittest.cc View 22 chunks +78 lines, -165 lines 0 comments Download
M content/browser/download/download_manager_impl.h View 9 chunks +27 lines, -23 lines 0 comments Download
M content/browser/download/download_manager_impl.cc View 17 chunks +141 lines, -57 lines 0 comments Download
M content/browser/download/download_manager_impl_unittest.cc View 18 chunks +81 lines, -60 lines 0 comments Download
M content/browser/download/download_resource_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/download/mock_download_file.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/download/mock_download_file.cc View 1 chunk +2 lines, -10 lines 0 comments Download
M content/browser/download/save_package.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host_impl.h View 3 chunks +8 lines, -0 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host_impl.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/content_browser.gypi View 2 chunks +2 lines, -3 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
D content/public/browser/download_destination_observer.h View 1 chunk +0 lines, -37 lines 0 comments Download
M content/public/browser/download_manager.h View 1 chunk +23 lines, -0 lines 0 comments Download
M content/public/test/mock_download_manager.h View 1 chunk +12 lines, -2 lines 0 comments Download
M content/public/test/test_file_error_injector.h View 6 chunks +16 lines, -18 lines 0 comments Download
M content/test/test_file_error_injector.cc View 13 chunks +169 lines, -151 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yuta Kitamura
8 years, 4 months ago (2012-08-14 09:44:27 UTC) #1
Yuta Kitamura
Please see http://code.google.com/p/chromium/issues/detail?id=123998#c13 for the reason of this revert. Thank you for your understanding!
8 years, 4 months ago (2012-08-14 09:48:37 UTC) #2
Randy Smith (Not in Mondays)
8 years, 4 months ago (2012-08-14 15:30:18 UTC) #3 
LGTM :-{.

Powered by Google App Engine
This is Rietveld 408576698