Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 10827311: Support new dmprof in perf_endure.py. (Closed)

Created:
8 years, 4 months ago by Dai Mikurube (NOT FULLTIME)
Modified:
8 years, 4 months ago
Reviewers:
dennis_jeffrey
CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1, Nirnimesh
Visibility:
Public.

Description

Support new dmprof in perf_endure.py. BUG=122119 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151672

Patch Set 1 #

Total comments: 2

Patch Set 2 : removed _CHROME_BIN_PATH #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M chrome/test/functional/perf_endure.py View 1 3 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Dai Mikurube (NOT FULLTIME)
Hi Dennis, dmprof has updated its command line. This change updates perf_endure.py for the change.
8 years, 4 months ago (2012-08-14 06:22:19 UTC) #1
dennis_jeffrey
LGTM with a nit. Thanks! http://codereview.chromium.org/10827311/diff/1/chrome/test/functional/perf_endure.py File chrome/test/functional/perf_endure.py (right): http://codereview.chromium.org/10827311/diff/1/chrome/test/functional/perf_endure.py#newcode62 chrome/test/functional/perf_endure.py:62: _CHROME_BIN_PATH = os.path.join(perf.BasePerfTest.BrowserPath(), 'chrome') ...
8 years, 4 months ago (2012-08-15 01:24:49 UTC) #2
Dai Mikurube (NOT FULLTIME)
Thank you. Will commit it soon. http://codereview.chromium.org/10827311/diff/1/chrome/test/functional/perf_endure.py File chrome/test/functional/perf_endure.py (right): http://codereview.chromium.org/10827311/diff/1/chrome/test/functional/perf_endure.py#newcode62 chrome/test/functional/perf_endure.py:62: _CHROME_BIN_PATH = os.path.join(perf.BasePerfTest.BrowserPath(), ...
8 years, 4 months ago (2012-08-15 02:04:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmikurube@chromium.org/10827311/6001
8 years, 4 months ago (2012-08-15 02:27:33 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-15 06:55:27 UTC) #5
Change committed as 151672

Powered by Google App Engine
This is Rietveld 408576698