Fix a misuse of framebuffer target in GLHelper (2)

Fix a misuse of framebuffer target in GLHelper (2)

EGL only recognizes the GL_FRAMEBUFFER target for
glFramebufferTexture2D.  Also mark GL_DRAW_FRAMEBUFFER
as an invalid parameter to OpenGLES framebuffer
object functions, as only GL_FRAMEBUFFER is valid.

Also, use the _EXT versions of framebuffer enums on other targets,
to regularize with the use of EXT functions.

BUG=chrome-os-partner:11070
TEST=local build, run on ARM

Change-Id: I14d495f0195491df186b60f164ce342e7e5c9463


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151637

[piman, 2012-08-14 22:27:13]

+gman.
I'm OK with the changes in the .cc files, but wondering about the changes in the
generator - does that mean we are disallowing the separate READ/DRAW bindings
even when we expose the extension?

[sheu, 2012-08-14 22:33:16]

I don't think there's an OpenGLES2 extension that exposes separate READ/DRAW
bindings -- GL_OES_framebuffer_object refers to EXT_framebuffer_object, which
doesn't have it either.

[mazda, 2012-08-14 22:39:17]

Thank you for tracking down this issue!
How about separating this CL into GLHelper part and the command buffer part?

[piman, 2012-08-14 22:40:49]

On 2012/08/14 22:33:16, sheu wrote:
> I don't think there's an OpenGLES2 extension that exposes separate READ/DRAW
> bindings -- GL_OES_framebuffer_object refers to EXT_framebuffer_object, which
> doesn't have it either.

GL_EXT_framebuffer_multisample/GL_ANGLE_framebuffer_multisample (that we expose
as GL_CHROMIUM_framebuffer_multisample, I don't know the exact semantic
differences).

It looks like we're manually allowing those enums when we support and enable the
extension (see feature_info.cc).
So it's probably fine to disable them by default.

So LGTM from me, but please wait for an ACK from gman.

[mazda, 2012-08-14 22:43:02]

LGTM for GLHelper.

[greggman, 2012-08-14 23:42:43]

lgtm

[commit-bot: I haz the power, 2012-08-14 23:44:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sheu@chromium.org/10827310/4001

[commit-bot: I haz the power, 2012-08-15 02:37:46]

Change committed as 151637