Issue 10827308: H/W decoded H.264 videos would not play at times on Windows 8. This was because the DXVA decoder in…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10827308: H/W decoded H.264 videos would not play at times on Windows 8. This was because the DXVA decoder in… (Closed)

Created:
8 years, 4 months ago by ananta

Modified:
8 years, 4 months ago

Reviewers:
Ami GONE FROM CHROMIUM

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

H/W decoded H.264 videos would not play at times on Windows 8. This was because the DXVA decoder in its processinput implementation was returning the error MF_A_NOTACCEPTING which was being treated as a platform failure code. This was incorrect. As per msdn when we get this error it means that the decoder has all the input it needs to produce one output sample. We need to call ProcessOutput and then ProcessInput again. Fixes bug http://code.google.com/p/chromium/issues/detail?id=140989 BUG=140989 R=fischman Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151503

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -0 lines)			Patch
	M	content/common/gpu/media/dxva_video_decode_accelerator.cc	View		1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages