Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 10827296: Butter bar visual refresh. (Closed)

Created:
8 years, 4 months ago by SeRya
Modified:
8 years, 4 months ago
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

Butter bar visual refresh. BUG=137610 TEST=Manual test. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151484

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -12 lines) Patch
M chrome/browser/resources/file_manager/css/file_manager.css View 1 3 chunks +20 lines, -3 lines 0 comments Download
M chrome/browser/resources/file_manager/js/butter_bar.js View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/file_manager/main.html View 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
SeRya
Oleg, please conduct preliminary review. I'm waiting for clarification from Josh regarding butter-bar colors.
8 years, 4 months ago (2012-08-13 10:45:22 UTC) #1
SeRya
8 years, 4 months ago (2012-08-13 12:33:27 UTC) #2
Vladislav Kaznacheev
https://chromiumcodereview.appspot.com/10827296/diff/1/chrome/browser/resources/file_manager/css/file_manager.css File chrome/browser/resources/file_manager/css/file_manager.css (right): https://chromiumcodereview.appspot.com/10827296/diff/1/chrome/browser/resources/file_manager/css/file_manager.css#newcode94 chrome/browser/resources/file_manager/css/file_manager.css:94: z-index: 3; I suspect this element would also need ...
8 years, 4 months ago (2012-08-13 13:27:18 UTC) #3
SeRya
We discussed overlaping issue with Josh and decided: 1. Use #e3e3e3 as a background color. ...
8 years, 4 months ago (2012-08-14 11:37:01 UTC) #4
Vladislav Kaznacheev
lgtm
8 years, 4 months ago (2012-08-14 12:33:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/serya@chromium.org/10827296/6001
8 years, 4 months ago (2012-08-14 13:05:26 UTC) #6
commit-bot: I haz the power
Try job failure for 10827296-6001 on linux_chromeos for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=32684 Step "update" is always ...
8 years, 4 months ago (2012-08-14 13:14:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/serya@chromium.org/10827296/6001
8 years, 4 months ago (2012-08-14 13:45:50 UTC) #8
commit-bot: I haz the power
8 years, 4 months ago (2012-08-14 15:59:10 UTC) #9
Change committed as 151484

Powered by Google App Engine
This is Rietveld 408576698