Add a commandline switch to run PerformanceMonitor

Add a commandline switch to run PerformanceMonitor

As PerformanceMonitor gets larger, it's appropriate to have an easy way of
turning it on in a build. This adds a commandline switch,
--run-performance-monitor.

BUG=130212
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151522

[Yoyo Zhou, 2012-08-13 19:37:19]

LGTM

http://codereview.chromium.org/10827290/diff/2001/chrome/common/chrome_switch...
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/10827290/diff/2001/chrome/common/chrome_switch...
chrome/common/chrome_switches.cc:1162: // usage; and will also store information
about events which may be of interest,
nit: either change the ; to a , or change "and" to "it"

http://codereview.chromium.org/10827290/diff/2001/chrome/common/chrome_switch...
chrome/common/chrome_switches.cc:1163: // such as extension-related occurences
and crashes.
nit: occurrences

[Devlin, 2012-08-13 20:05:31]

+ thakis for c/b changes

[Nico, 2012-08-13 20:09:08]

Neither the bug nor this CL describe what PerformanceMonitor actually is and
what it does. Can you give me a short overview?

[Devlin, 2012-08-13 20:17:01]

On 2012/08/13 20:09:08, Nico wrote:
> Neither the bug nor this CL describe what PerformanceMonitor actually is and
> what it does. Can you give me a short overview?

Good point; sorry about that.
Verbose version:
https://docs.google.com/a/chromium.org/document/d/1GhiAly7eRlkH5wfuGAEy53soLI...

Cliffnotes: PerformanceMonitor is going to keep track of Chrome's performance
through recording various statistics (such as CPU usage, memory usage, page
loads times, etc), and significant events (extension related events like
installs/uninstalls, crashes, unclean exits, etc). It will then be able to
display this information in graphical form. The goal is to be able to see trends
in Chrome's performance, and perhaps diagnose a reason that chrome is acting
differently.
Example:
User notices chrome is acting slow.
User looks at PerformanceMonitor and sees the CPU usage went up and page load
times increased on day x.
User looks at events for day x and sees that an MyBadlyWrittenExtension was
installed.
User uninstalls the extension, and is happy once more.

The project is still in relatively early stages, but the framework is down. This
allows us to turn it on from the commandline.

If you have any other questions, feel free to respond here, email, or IRC :)

[Nico, 2012-08-13 21:40:49]

lgtm

Sorry, I didn't see the design doc linked from the bug, even though the link was
there :-/

[Devlin, 2012-08-14 16:13:54]

https://chromiumcodereview.appspot.com/10827290/diff/2001/chrome/common/chrom...
File chrome/common/chrome_switches.cc (right):

https://chromiumcodereview.appspot.com/10827290/diff/2001/chrome/common/chrom...
chrome/common/chrome_switches.cc:1162: // usage; and will also store information
about events which may be of interest,
On 2012/08/13 19:37:20, Yoyo Zhou wrote:
> nit: either change the ; to a , or change "and" to "it"

Done.

https://chromiumcodereview.appspot.com/10827290/diff/2001/chrome/common/chrom...
chrome/common/chrome_switches.cc:1163: // such as extension-related occurences
and crashes.
On 2012/08/13 19:37:20, Yoyo Zhou wrote:
> nit: occurrences

Wow, I can't spell this word for the life of me...
(*gets curious*)
$ git grep --ignore-case -e "occurance"  --or -e "occurrance" --or -e
"occurence" | wc
$ 81     827    8327
$ git grep --ignore-case "occurrence" | wc
$ 321    3025   33445
At least I'm not alone :) Thanks for catching this (again)!

[commit-bot: I haz the power, 2012-08-14 16:14:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/10827290/1...

[commit-bot: I haz the power, 2012-08-14 18:42:07]

Change committed as 151522