Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: runtime/vm/dart_api_impl_test.cc

Issue 10827288: - Support for patching of class methods and fields. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/dart_api_impl_test.cc
===================================================================
--- runtime/vm/dart_api_impl_test.cc (revision 10615)
+++ runtime/vm/dart_api_impl_test.cc (working copy)
@@ -5481,6 +5481,7 @@
"class A {\n"
" var _f;\n"
" external method(var value);\n"
+ " get field() => _field;\n"
"}\n"
"external int unpatched();\n"
"external int topLevel(var value);\n"
@@ -5488,7 +5489,14 @@
"external void set topLevelSetter(int value);\n";
const char* kPatchChars =
- "var _topLevelValue = -1;"
+ "patch class A {\n"
+ " var _g;\n"
+ " get _field() => _g;\n"
+ " patch method(var value) {\n"
+ " _g = value * 5;\n"
+ " }\n"
+ "}\n"
+ "var _topLevelValue = -1;\n"
"patch int topLevel(var value) => value * value;\n"
"patch int set topLevelSetter(value) { _topLevelValue = value; }\n"
"patch int get topLevelGetter() => 2 * _topLevelValue;\n"
@@ -5503,7 +5511,12 @@
" topLevelSetter = 20;\n"
" return topLevelGetter;\n"
"}\n"
- "m3() => patch(7);\n";
+ "m3() => patch(7);\n"
+ "m4() {\n"
+ " var a = new A();\n"
+ " a.method(5);\n"
+ " return a.field;\n"
+ "}\n";
Dart_Handle result = Dart_SetLibraryTagHandler(library_handler);
EXPECT_VALID(result);
@@ -5554,6 +5567,13 @@
EXPECT(Dart_IsInteger(result));
EXPECT_VALID(Dart_IntegerToInt64(result, &value));
EXPECT_EQ(21, value);
+
+ value = 0;
+ result = Dart_Invoke(test_script, Dart_NewString("m4"), 0, NULL);
+ EXPECT_VALID(result);
+ EXPECT(Dart_IsInteger(result));
+ EXPECT_VALID(Dart_IntegerToInt64(result, &value));
+ EXPECT_EQ(25, value);
}
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/debugger.cc » ('j') | runtime/vm/object.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698