Issue 10827282: Move the injection test API to content/public.

Issue 10827282: Move the injection test API to content/public. (Closed)

Created:
8 years, 4 months ago by Avi (use Gerrit)

Modified:
8 years, 4 months ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move the injection test API to content/public. BUG=139631, 98716 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151087

Patch Set 3 : gypi #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -17 lines)			Patch
M	chrome/chrome_tests.gypi	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/test/DEPS	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/test/security_tests/renderer_sandbox_tests_mac.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/security_tests/security_tests.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/security_tests/security_tests.gyp	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/content_common.gypi	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/plugin/plugin_main.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	content/public/common/injection_test_mac.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A +	content/public/common/injection_test_win.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	content/renderer/DEPS	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	content/renderer/renderer_main_platform_delegate_mac.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/renderer_main_platform_delegate_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

jam

did you forget to delete content/common/injection_test_dll.h? https://chromiumcodereview.appspot.com/10827282/diff/1/chrome/chrome_tests.gypi File chrome/chrome_tests.gypi (right): https://chromiumcodereview.appspot.com/10827282/diff/1/chrome/chrome_tests.gypi#newcode4099 chrome/chrome_tests.gypi:4099: '../content/public/common/injection_test_mac.h', no need ...

8 years, 4 months ago (2012-08-10 17:04:57 UTC) #2

Avi (use Gerrit)

I don't know what's up with the non-deleted files. I'm using git with this; I ...

8 years, 4 months ago (2012-08-10 17:10:22 UTC) #3

jam

On 2012/08/10 17:10:22, Avi wrote: > I don't know what's up with the non-deleted files. ...

8 years, 4 months ago (2012-08-10 17:12:47 UTC) #4

lgtm

Expand Messages | Collapse Messages