Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Unified Diff: chrome/browser/extensions/extension_install_ui_browsertest.cc

Issue 10827278: Mark ExtensionInstallUIBrowserTest.AppInstallConfirmation and AppInstallConfirmation_Incognito as f… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_install_ui_browsertest.cc
===================================================================
--- chrome/browser/extensions/extension_install_ui_browsertest.cc (revision 151027)
+++ chrome/browser/extensions/extension_install_ui_browsertest.cc (working copy)
@@ -101,8 +101,14 @@
EXPECT_EQ(theme, GetTheme());
}
+#if defined(OS_WIN)
+// http://crbug.com/141854
+#define MAYBE_AppInstallConfirmation FLAKY_AppInstallConfirmation
+#else
+#define MAYBE_AppInstallConfirmation AppInstallConfirmation
+#endif
IN_PROC_BROWSER_TEST_F(ExtensionInstallUIBrowserTest,
- AppInstallConfirmation) {
+ MAYBE_AppInstallConfirmation) {
int num_tabs = browser()->tab_count();
FilePath app_dir = test_data_dir_.AppendASCII("app");
@@ -119,8 +125,15 @@
}
}
+#if defined(OS_WIN)
+// http://crbug.com/141854
+#define MAYBE_AppInstallConfirmation_Incognito \
+ FLAKY_AppInstallConfirmation_Incognito
+#else
+#define MAYBE_AppInstallConfirmation_Incognito AppInstallConfirmation_Incognito
+#endif
IN_PROC_BROWSER_TEST_F(ExtensionInstallUIBrowserTest,
- AppInstallConfirmation_Incognito) {
+ MAYBE_AppInstallConfirmation_Incognito) {
Profile* incognito_profile = browser()->profile()->GetOffTheRecordProfile();
Browser* incognito_browser =
new Browser(Browser::CreateParams(incognito_profile));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698