Change Android build configurations (step 1).

Change Android build configurations (step 1).
   
Before this change we build Release builds size-optimized code with DCHECK,
while we almost never use the Debug build which is not size-optimized.
    
Now change Debug build to build size-optimized code with DCHECK but still
temporarily keep Release build and default configuration unchanged before
everyone (the bots, scripts and developers) knows how to deal with this change.
    
Next steps will be:
    
Step 2: update developer scripts and buildbot scripts to handle the new
configuration.
    
Step 3: change Release configuration to no DCHECK and change default
configuration to Debug.
    
After all steps finish, this new configuration will better match Chromium
and WebKit (e.g. better matches the DEBUG and RELEASE tags in WebKit layout
test expectations), and makes it easier to build a performance build.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151589

[Xianzhu, 2012-08-10 04:15:44]

http://codereview.chromium.org/10827273/diff/1/build/android/pylib/single_tes...
File build/android/pylib/single_test_runner.py (right):

http://codereview.chromium.org/10827273/diff/1/build/android/pylib/single_tes...
build/android/pylib/single_test_runner.py:51: logging.warning('Test suite: ' +
test_suite)
This is printed because I think it's important to know which test suite (Debug
or Release) is being run.

[Yaron, 2012-08-10 17:41:29]

Not really comfortable reviewing this change. Adding Satish

[Satish, 2012-08-13 14:52:46]

+torne for gyp changes and if it may affect webview
+bulach for test runner changes

The CL looks fine to me but would like the above two to lgtm. Do you have any
numbers on the output binary size with the new debug-optimised configuration?

[Torne, 2012-08-13 15:08:28]

Shouldn't be any WebView-specific problems with this, but I do have one major
comment:

http://codereview.chromium.org/10827273/diff/1/build/common.gypi
File build/common.gypi (left):

http://codereview.chromium.org/10827273/diff/1/build/common.gypi#oldcode1942
build/common.gypi:1942: 'defines!': ['NDEBUG'],
Removing this now seems like a bad idea. If this is changed before we switch the
default, this means that *nobody* will be building with DCHECKs enabled, which
means there is a serious risk they will regress and become broken. Can we land
the change to update the Debug configuration, then switch the default to Debug,
and *then* remove DCHECKs from Release instead please?

[Xianzhu, 2012-08-13 16:58:29]

On 2012/08/13 14:52:46, Satish wrote:
> +torne for gyp changes and if it may affect webview
> +bulach for test runner changes
> 
> The CL looks fine to me but would like the above two to lgtm. Do you have any
> numbers on the output binary size with the new debug-optimised configuration?

The size is almost the same as the original Release build. Will give exact
numbers when my current builds finish.

[Xianzhu, 2012-08-13 16:58:34]

http://codereview.chromium.org/10827273/diff/1/build/common.gypi
File build/common.gypi (left):

http://codereview.chromium.org/10827273/diff/1/build/common.gypi#oldcode1942
build/common.gypi:1942: 'defines!': ['NDEBUG'],
On 2012/08/13 15:08:28, Torne wrote:
> Removing this now seems like a bad idea. If this is changed before we switch
the
> default, this means that *nobody* will be building with DCHECKs enabled, which
> means there is a serious risk they will regress and become broken. Can we land
> the change to update the Debug configuration, then switch the default to
Debug,
> and *then* remove DCHECKs from Release instead please?

Agreed. Done.

[Xianzhu, 2012-08-13 18:13:13]

On 2012/08/13 14:52:46, Satish wrote:
> +torne for gyp changes and if it may affect webview
> +bulach for test runner changes
> 
> The CL looks fine to me but would like the above two to lgtm. Do you have any
> numbers on the output binary size with the new debug-optimised configuration?

Debug:
  stripped: 37608344
  unstripped: 1969691380

Release:
  stripped: 37185208
  unstripped: 1969836960

[Torne, 2012-08-13 19:33:42]

lgtm

[commit-bot: I haz the power, 2012-08-13 20:34:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/10827273/7001

[commit-bot: I haz the power, 2012-08-13 23:02:44]

Try job failure for 10827273-7001 (retry) on win_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-08-13 23:57:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/10827273/7001

[commit-bot: I haz the power, 2012-08-14 01:08:31]

Try job failure for 10827273-7001 (retry) on linux_rel for step
"content_unittests".
It's a second try, previously, step "content_unittests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-08-14 16:25:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/10827273/7001

[commit-bot: I haz the power, 2012-08-14 18:14:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/10827273/10003

[commit-bot: I haz the power, 2012-08-14 22:42:56]

Change committed as 151589