Issue 10827267: Remove unused include and always-true compile-time check

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10827267: Remove unused include and always-true compile-time check (Closed)

Created:
8 years, 4 months ago by jamesr

Modified:
8 years, 4 months ago

Reviewers:
piman

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove unused include and always-true compile-time check BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150986

Patch Set 1 #

Patch Set 2 : Kill all WEBCOMPOSITOR_OWNS_SETTINGS related code #

Patch Set 3 : rebased #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -50 lines)			Patch
M	content/browser/web_contents/web_contents_impl.cc	View	1 2	2 chunks	+0 lines, -10 lines	0 comments	Download
M	content/common/view_messages.h	View	1 2	2 chunks	+0 lines, -6 lines	0 comments	Download
M	content/renderer/render_thread_impl.cc	View	1 2	3 chunks	+2 lines, -4 lines	0 comments	Download
M	ui/compositor/compositor.cc	View	1 2	2 chunks	+0 lines, -9 lines	0 comments	Download
M	webkit/glue/webpreferences.h	View	1	2 chunks	+0 lines, -6 lines	0 comments	Download
M	webkit/glue/webpreferences.cc	View		2 chunks	+0 lines, -15 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

jamesr

WEBCOMPOSITOR_OWNS_SETTINGS has been set since mid-june http://trac.webkit.org/changeset/120360/trunk/Source/WebKit/chromium/public/WebCompositor.h, it's time to kill the #ifdefs. I've also ...

8 years, 4 months ago (2012-08-10 00:11:29 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/10827267/10006

8 years, 4 months ago (2012-08-10 01:20:01 UTC) #5

Change committed as 150986

Expand Messages | Collapse Messages